Use _.where when searching for existing filters

Author: jeff-phillips-18

dist/angular-patternfly.js

@@ -1730,13 +1730,8 @@ angular.module('patternfly.filters').directive('pfSimpleFilter',
       templateUrl: 'filters/simple-filter.html',
       controller: ["$scope", function ($scope) {
         $scope.filterExists = function (filter) {
-          var found = false;
-          $scope.config.appliedFilters.forEach(function (nextFilter) {
-            if (nextFilter.title === filter.title && nextFilter.value === filter.value) {
-              found = true;
-            }
-          });
-          return found;
+          var foundFilter = _.findWhere($scope.config.appliedFilters, {title: filter.title, value: filter.value});
+          return foundFilter !== undefined;
         };
 
         $scope.addFilter = function (field, value) {
@@ -4031,13 +4026,8 @@ angular.module('patternfly.views').directive('pfDataToolbar',
         };
 
         $scope.filterExists = function (filter) {
-          var found = false;
-          $scope.config.filterConfig.appliedFilters.forEach(function (nextFilter) {
-            if (nextFilter.title === filter.title && nextFilter.value === filter.value) {
-              found = true;
-            }
-          });
-          return found;
+          var foundFilter = _.findWhere($scope.config.filterConfig.appliedFilters, {title: filter.title, value: filter.value});
+          return foundFilter !== undefined;
         };
 
         $scope.addFilter = function (field, value) {

dist/angular-patternfly.min.js

@@ -180,13 +180,8 @@ angular.module('patternfly.filters').directive('pfSimpleFilter',
       templateUrl: 'filters/simple-filter.html',
       controller: function ($scope) {
         $scope.filterExists = function (filter) {
-          var found = false;
-          $scope.config.appliedFilters.forEach(function (nextFilter) {
-            if (nextFilter.title === filter.title && nextFilter.value === filter.value) {
-              found = true;
-            }
-          });
-          return found;
+          var foundFilter = _.findWhere($scope.config.appliedFilters, {title: filter.title, value: filter.value});
+          return foundFilter !== undefined;
         };
 
         $scope.addFilter = function (field, value) {

src/filters/simple-filter-directive.js

@@ -233,13 +233,8 @@ angular.module('patternfly.views').directive('pfDataToolbar',
         };
 
         $scope.filterExists = function (filter) {
-          var found = false;
-          $scope.config.filterConfig.appliedFilters.forEach(function (nextFilter) {
-            if (nextFilter.title === filter.title && nextFilter.value === filter.value) {
-              found = true;
-            }
-          });
-          return found;
+          var foundFilter = _.findWhere($scope.config.filterConfig.appliedFilters, {title: filter.title, value: filter.value});
+          return foundFilter !== undefined;
         };
 
         $scope.addFilter = function (field, value) {