Merge pull request #680 from akieling/angular-patternfly-667

dtaylor113 · web-flow · commit 8a0a5f4ac1a7 · 2017-11-27T09:35:35.000-05:00
fix(pfTableView): fix access to invalid array item
diff --git a/src/table/tableview/table-view.component.js b/src/table/tableview/table-view.component.js
@@ -378,7 +378,7 @@ angular.module('patternfly.table').component('pfTableView', {
 
       for (i = 0; i < anNodes.length; ++i) {
         rowData = anNodes[i].cells;
-        if (rowData !== null) {
+        if (rowData !== null && rowData.length > ctrl.selectionMatchPropColNum) {
           visibleRows.push(_.trim(rowData[ctrl.selectionMatchPropColNum].innerText));
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,7 @@ angular.module('patternfly.table').component('pfTableView', {`
`378`	`378`
`379`	`379`	`for (i = 0; i < anNodes.length; ++i) {`
`380`	`380`	`rowData = anNodes[i].cells;`
`381`		`- if (rowData !== null) {`
	`381`	`+ if (rowData !== null && rowData.length > ctrl.selectionMatchPropColNum) {`
`382`	`382`	`visibleRows.push(_.trim(rowData[ctrl.selectionMatchPropColNum].innerText));`
`383`	`383`	`}`
`384`	`384`	`}`