Merge pull request #555 from dtaylor113/pfFilterPanelFix

jeff-phillips-18 · web-flow · commit 96f4781630d7 · 2017-08-08T09:14:02.000-04:00
Small fix to pfFilterPanelResults when clearing a filter
diff --git a/src/filters/filter-panel/filter-panel-results-component.js b/src/filters/filter-panel/filter-panel-results-component.js
@@ -60,14 +60,14 @@ angular.module('patternfly.filters').component('pfFilterPanelResults', {
     function clearFilter (filter, value) {
       var changedFilterId = filter.id;
 
-      var changedFilterValue = _.pull(filter.values, value)[0];
+      _.pull(filter.values, value);
 
       if (filter.values.length === 0) {
         _.pull(ctrl.config.appliedFilters, filter);
       }
 
       if (ctrl.config.onFilterChange) {
-        ctrl.config.onFilterChange(ctrl.config.appliedFilters, changedFilterId, changedFilterValue);
+        ctrl.config.onFilterChange(ctrl.config.appliedFilters, changedFilterId, value);
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -60,14 +60,14 @@ angular.module('patternfly.filters').component('pfFilterPanelResults', {`
`60`	`60`	`function clearFilter (filter, value) {`
`61`	`61`	`var changedFilterId = filter.id;`
`62`	`62`
`63`		`- var changedFilterValue = _.pull(filter.values, value)[0];`
	`63`	`+ _.pull(filter.values, value);`
`64`	`64`
`65`	`65`	`if (filter.values.length === 0) {`
`66`	`66`	`_.pull(ctrl.config.appliedFilters, filter);`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`if (ctrl.config.onFilterChange) {`
`70`		`- ctrl.config.onFilterChange(ctrl.config.appliedFilters, changedFilterId, changedFilterValue);`
	`70`	`+ ctrl.config.onFilterChange(ctrl.config.appliedFilters, changedFilterId, value);`
`71`	`71`	`}`
`72`	`72`	`}`
`73`	`73`