Skip to content

Commit a7d9837

Browse files
committed
Hides selected filter results unless selected&totalCount !== undefined
Unless selectedcount and total count are explicitly defined, will not display the "x of x selected" filter results text. Prevents unwanted text for instance, when there is no items to select
1 parent 7ea7c41 commit a7d9837

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

src/filters/filter-results-component.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,6 @@ angular.module('patternfly.filters').component('pfFilterResults', {
6363
if (ctrl.config.resultsCount === undefined) {
6464
ctrl.config.resultsCount = 0;
6565
}
66-
if (ctrl.config.selectedCount === undefined) {
67-
ctrl.config.selectedCount = 0;
68-
}
69-
if (ctrl.config.totalCount === undefined) {
70-
ctrl.config.totalCount = 0;
71-
}
7266
}
7367

7468
function clearFilter (item) {

src/filters/filter-results.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ <h5>{{$ctrl.config.resultsCount}} Results</h5>
1212
</li>
1313
</ul>
1414
<p><a class="clear-filters" ng-click="$ctrl.clearAllFilters()" ng-if="$ctrl.config.appliedFilters.length > 0">Clear All Filters</a></p>
15-
<div ng-if="$ctrl.config.totalCount !== 0" class="pf-table-view-selected-label">
15+
<div ng-if="$ctrl.config.selectedCount !== undefined && $ctrl.config.totalCount !== undefined" class="pf-table-view-selected-label">
1616
<strong>{{$ctrl.config.selectedCount}}</strong> of <strong>{{$ctrl.config.totalCount}}</strong> selected
1717
</div>
1818
</div><!-- /col -->

0 commit comments

Comments
 (0)