Skip to content

Commit ba86539

Browse files
authored
Merge pull request #358 from jjlangholtz/fix-filter-dropdowns-for-pf-card
Fix filter dropdowns for pf card directives
2 parents c0af6e8 + f13c0c0 commit ba86539

File tree

2 files changed

+15
-17
lines changed

2 files changed

+15
-17
lines changed

src/card/basic/card-filter.html

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
1-
<button type="button" uib-dropdown-toggle class="btn btn-default">
2-
{{currentFilter.label}}
3-
<span class="caret"></span>
4-
</button>
5-
<ul uib-dropdown-menu class="dropdown-menu-right" role="menu">
6-
<li ng-repeat="item in filter.filters" ng-class="{'selected': item === currentFilter}">
7-
<a role="menuitem" tabindex="-1" ng-click="filterCallBackFn(item)">
8-
{{item.label}}
9-
</a>
10-
</li>
11-
</ul>
1+
<div uib-dropdown class="card-pf-time-frame-filter">
2+
<button type="button" uib-dropdown-toggle class="btn btn-default">
3+
{{currentFilter.label}}
4+
<span class="caret"></span>
5+
</button>
6+
<ul uib-dropdown-menu class="dropdown-menu-right" role="menu">
7+
<li ng-repeat="item in filter.filters" ng-class="{'selected': item === currentFilter}">
8+
<a role="menuitem" tabindex="-1" ng-click="filterCallBackFn(item)">
9+
{{item.label}}
10+
</a>
11+
</li>
12+
</ul>
13+
</div>

src/card/basic/card.html

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<div ng-class="showTopBorder === 'true' ? 'card-pf card-pf-accented' : 'card-pf'">
22
<div ng-if="showHeader()" ng-class="shouldShowTitlesSeparator ? 'card-pf-heading' : 'card-pf-heading-no-bottom'">
3-
<div ng-if="showFilterInHeader()" uib-dropdown class="card-pf-time-frame-filter">
4-
<div ng-include="'card/basic/card-filter.html'"></div>
5-
</div>
3+
<div ng-if="showFilterInHeader()" ng-include="'card/basic/card-filter.html'"></div>
64
<h2 class="card-pf-title">{{headTitle}}</h2>
75
</div>
86

@@ -12,9 +10,7 @@ <h2 class="card-pf-title">{{headTitle}}</h2>
1210
<div ng-transclude></div>
1311
</div>
1412
<div ng-if="footer" class="card-pf-footer">
15-
<div ng-if="showFilterInFooter()" uib-dropdown class="card-pf-time-frame-filter">
16-
<div ng-include="'card/basic/card-filter.html'"></div>
17-
</div>
13+
<div ng-if="showFilterInFooter()" ng-include="'card/basic/card-filter.html'"></div>
1814
<p>
1915
<a ng-if="footer.href" href="{{footer.href}}" ng-class="{'card-pf-link-with-icon':footer.iconClass,'card-pf-link':!footer.iconClass}">
2016
<span ng-if="footer.iconClass" class="{{footer.iconClass}} card-pf-footer-text"></span>

0 commit comments

Comments
 (0)