Skip to content

Commit c5ccbf2

Browse files
authored
Merge pull request #424 from jeff-phillips-18/branch-4.0-dev
Cherry Pick Master Branch Changes since Alpha 2
2 parents 832e618 + 7a7f01d commit c5ccbf2

File tree

5 files changed

+19
-21
lines changed

5 files changed

+19
-21
lines changed

.travis.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,3 @@ script:
2121

2222
after_success:
2323
- ./scripts/publish-ghpages.sh -t docs
24-
25-
# OpenShift expects its deployment branch to be "master-dist". This can be changed using:
26-
# rhc app-configure patternfly/angular --deployment-branch master-dist
27-
deploy:
28-
provider: openshift
29-
user: "$OPENSHIFT_USER"
30-
password: "$OPENSHIFT_PWD"
31-
domain: "patternfly"
32-
app: angular
33-
skip_cleanup: true
34-
on: # The branch and repo that triggered the build
35-
branch: master
36-
condition: $TRAVIS_REPO_SLUG = "patternfly/angular-patternfly"

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
This project will provide a set of common AngularJS directives for use with the PatternFly reference implementation.
1010

1111
* Web site: https://www.patternfly.org
12-
* API Docs: http://angular-patternfly.rhcloud.com/#/api
12+
* API Docs: http://www.patternfly.org/angular-patternfly/#/api
1313
* Build Status: https://travis-ci.org/patternfly/angular-patternfly.svg?branch=master
1414

1515
## Getting started

src/charts/line/line-chart.component.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@
6262
</div>
6363
<div class="col-md-3">
6464
<button ng-click="addDataPoint()">Add Data Point</button>
65+
<button ng-click="resetData()">Reset Data</button>
6566
</div>
6667
</div>
6768
</div>
@@ -100,8 +101,8 @@
100101
$scope.data = {
101102
dataAvailable: true,
102103
xData: dates,
103-
yData0: ['Created', 12, 10,10, 62, 17, 10, 15, 13, 17, 10, 12, 10, 10, 12, 17, 16, 15, 13, 17, 10],
104-
yData1: ['Deleted', 10, 17, 76,14, 10, 10, 10, 10, 10, 10, 10, 17, 17, 14, 10, 10, 10, 10, 10, 10]
104+
yData0: ['Created', 12, 10, 10, 62, 17, 10, 15, 13, 17, 10, 12, 10, 10, 12, 17, 16, 15, 13, 17, 10],
105+
yData1: ['Deleted', 10, 17, 76, 14, 10, 10, 10, 10, 10, 10, 10, 17, 17, 14, 10, 10, 10, 10, 10, 10]
105106
};
106107
107108
$scope.custShowXAxis = false;
@@ -113,6 +114,14 @@
113114
$scope.data.yData0.push(Math.round(Math.random() * 100));
114115
$scope.data.yData1.push(Math.round(Math.random() * 100));
115116
};
117+
118+
$scope.resetData = function () {
119+
$scope.data = {
120+
xData: dates,
121+
yData0: ['Created', 12, 10, 10, 62],
122+
yData1: ['Deleted', 10, 17, 76, 14]
123+
};
124+
};
116125
});
117126
</file>
118127
</example>
@@ -188,7 +197,7 @@ angular.module('patternfly.charts').component('pfLineChart', {
188197
}
189198

190199
// Convert the given data to C3 chart format
191-
ctrl.config.data = pfUtils.merge(ctrl.config.data, ctrl.getLineData(ctrl.chartData));
200+
ctrl.config.data = ctrl.getLineData(ctrl.chartData);
192201

193202
// Override defaults with callers specifications
194203
ctrl.defaultConfig = pfUtils.merge(ctrl.defaultConfig, ctrl.config);

src/filters/examples/filter.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,12 @@
9494
9595
var matchesFilter = function (item, filter) {
9696
var match = true;
97+
var re = new RegExp(filter.value, 'i');
9798
9899
if (filter.id === 'name') {
99-
match = item.name.match(filter.value) !== null;
100+
match = item.name.match(re) !== null;
100101
} else if (filter.id === 'address') {
101-
match = item.address.match(filter.value) !== null;
102+
match = item.address.match(re) !== null;
102103
} else if (filter.id === 'birthMonth') {
103104
match = item.birthMonth === filter.value;
104105
}

src/toolbars/examples/toolbar.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,13 +234,14 @@
234234
235235
var matchesFilter = function (item, filter) {
236236
var match = true;
237+
var re = new RegExp(filter.value, 'i');
237238
238239
if (filter.id === 'name') {
239-
match = item.name.match(filter.value) !== null;
240+
match = item.name.match(re) !== null;
240241
} else if (filter.id === 'age') {
241242
match = item.age === parseInt(filter.value);
242243
} else if (filter.id === 'address') {
243-
match = item.address.match(filter.value) !== null;
244+
match = item.address.match(re) !== null;
244245
} else if (filter.id === 'birthMonth') {
245246
match = item.birthMonth === filter.value;
246247
}

0 commit comments

Comments
 (0)