Fixing outdated notifications icons

Author: erundle

dist/angular-patternfly.js

@@ -543,7 +543,7 @@ angular.module( 'patternfly.charts' )
          'used': '670',
          'total': '1000'
      };
-   }]);
+  }]);
  </file>
  </example>
  */
@@ -2195,7 +2195,7 @@ angular.module('patternfly.validation', []).directive('pfValidation', function (
 
 
   $templateCache.put('notification/notification.html',
-    "<div class=\"alert alert-{{pfNotificationType}}\"><button ng-show=pfNotificationPersistent type=button class=close ng-click=$parent.notifications.remove($index)><span aria-hidden=true>&times;</span><span class=sr-only>Close</span></button> <span class=\"pficon pficon-ok\" ng-show=\"pfNotificationType == 'success'\"></span> <span class=\"pficon pficon-info\" ng-show=\"pfNotificationType == 'info'\"></span> <span class=pficon-layered ng-show=\"pfNotificationType == 'danger'\"><span class=\"pficon pficon-error-octagon\"></span> <span class=\"pficon pficon-error-exclamation\"></span></span> <span class=pficon-layered ng-show=\"pfNotificationType == 'warning'\"><span class=\"pficon pficon-warning-triangle\"></span> <span class=\"pficon pficon-warning-exclamation\"></span></span> <strong>{{pfNotificationHeader}}</strong> {{pfNotificationMessage}}</div>"
+    "<div class=\"alert alert-{{pfNotificationType}}\"><button ng-show=pfNotificationPersistent type=button class=close ng-click=$parent.notifications.remove($index)><span aria-hidden=true>&times;</span><span class=sr-only>Close</span></button> <span class=\"pficon pficon-ok\" ng-show=\"pfNotificationType === 'success'\"></span> <span class=\"pficon pficon-info\" ng-show=\"pfNotificationType === 'info'\"></span> <span class=\"pficon pficon-error-circle-o\" ng-show=\"pfNotificationType === 'danger'\"></span> <span class=\"pficon pficon-warning-triangle-o\" ng-show=\"pfNotificationType === 'warning'\"></span> <strong>{{pfNotificationHeader}}</strong> {{pfNotificationMessage}}</div>"
   );
 
 }]);

dist/angular-patternfly.min.js

@@ -21,7 +21,7 @@
     "grunt-eslint": "^17.1.0",
     "grunt-htmlhint": "0.4.1",
     "grunt-karma": "0.8.3",
-    "grunt-ngdocs": "0.2.5",
+    "grunt-ngdocs": "0.2.9",
     "karma": "0.12.23",
     "karma-chrome-launcher": "0.1.4",
     "karma-firefox-launcher": "0.1.3",

package.json

@@ -207,7 +207,7 @@ angular.module( 'patternfly.charts' )
          'used': '670',
          'total': '1000'
      };
-   }]);
+  }]);
  </file>
  </example>
  */

src/charts/donut/donut-pct-chart-directive.js

@@ -4,15 +4,9 @@
     <span aria-hidden="true">&times;</span><span class="sr-only">Close</span>
   </button>
 
-  <span class="pficon pficon-ok" ng-show="pfNotificationType == 'success'"></span>
-  <span class="pficon pficon-info" ng-show="pfNotificationType == 'info'"></span>
-  <span class="pficon-layered" ng-show="pfNotificationType == 'danger'">
-    <span class="pficon pficon-error-octagon"></span>
-    <span class="pficon pficon-error-exclamation"></span>
-  </span>
-  <span class="pficon-layered" ng-show="pfNotificationType == 'warning'">
-    <span class="pficon pficon-warning-triangle"></span>
-    <span class="pficon pficon-warning-exclamation"></span>
-  </span>
+  <span class="pficon pficon-ok" ng-show="pfNotificationType === 'success'"></span>
+  <span class="pficon pficon-info" ng-show="pfNotificationType === 'info'"></span>
+  <span class="pficon pficon-error-circle-o" ng-show="pfNotificationType === 'danger'"></span>
+  <span class="pficon pficon-warning-triangle-o" ng-show="pfNotificationType === 'warning'"></span>
   <strong>{{pfNotificationHeader}}</strong> {{pfNotificationMessage}}
 </div>

src/notification/notification.html

@@ -79,14 +79,8 @@ describe('pf-notification', function () {
       var alertElement = angular.element(notifyElement.children().get(0));
       var iconOk = angular.element(alertElement.find('span.pficon-ok'));
       var iconInfo = angular.element(alertElement.find('span.pficon-info'));
-      var iconError = angular.element(alertElement.find('span.pficon-layered').get(0));
-      var iconWarning = angular.element(alertElement.find('span.pficon-layered').get(1));
-
-      var iE = iconError.find('span.pficon-error-octagon');
-      var iW = iconWarning.find('span.pficon-warning-triangle');
-
-      expect(iE[0]).toBeTruthy();
-      expect(iW[0]).toBeTruthy();
+      var iconError = angular.element(alertElement.find('span.pficon-error-circle-o'));
+      var iconWarning = angular.element(alertElement.find('span.pficon-warning-triangle-o'));
 
       expect(alertElement.text()).toContain('×Close');
       expect(alertElement.text()).toContain('head1 defaultMes');