Skip to content

Commit f9f1932

Browse files
committed
Remove replace attribute from directives (and fix unit test that broke).
1 parent 1f45804 commit f9f1932

File tree

6 files changed

+1
-7
lines changed

6 files changed

+1
-7
lines changed

src/wizard/wizard-buttons.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ function wizardButtonDirective (action) {
55
.directive(action, function () {
66
return {
77
restrict: 'A',
8-
replace: false,
98
require: '^pf-wizard',
109
scope: {
1110
callback: "=?"

src/wizard/wizard-directive.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,6 @@ angular.module('patternfly.wizard').directive('pfWizard', function ($window) {
299299
return {
300300
restrict: 'A',
301301
transclude: true,
302-
replace: true,
303302
scope: {
304303
title: '@',
305304
hideIndicators: '=?',
@@ -360,7 +359,6 @@ angular.module('patternfly.wizard').directive('pfWizard', function ($window) {
360359
// Add watchers for the selected step
361360
$scope.nextStepEnabledWatcher = $scope.$watch('selectedStep.nextEnabled', function (value) {
362361
$scope.nextEnabled = value;
363-
//console.log('next enabled: ' + value);
364362
});
365363
$scope.nextStepTooltipWatcher = $scope.$watch('selectedStep.nextTooltip', function (value) {
366364
$scope.nextTooltip = value;

src/wizard/wizard-review-page-directive.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ angular.module('patternfly.wizard').directive('pfWizardReviewPage', function ()
1313
'use strict';
1414
return {
1515
restrict: 'A',
16-
replace: true,
1716
scope: {
1817
shown: '=',
1918
wizardData: "="

src/wizard/wizard-step-directive.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ angular.module('patternfly.wizard').directive('pfWizardStep', function () {
2727
'use strict';
2828
return {
2929
restrict: 'A',
30-
replace: true,
3130
transclude: true,
3231
scope: {
3332
stepTitle: '@',

src/wizard/wizard-substep-directive.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ angular.module('patternfly.wizard').directive('pfWizardSubstep', function () {
2323

2424
return {
2525
restrict: 'A',
26-
replace: true,
2726
transclude: true,
2827
scope: {
2928
stepTitle: '@',

test/wizard/wizard.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ describe('Directive: pfWizard', function () {
190190
eventFire(indicator[1], 'click');
191191
$scope.$digest();
192192

193-
var selectedSectionTitle = element.find('.wizard-pf-row section.current').attr("step-title");
193+
var selectedSectionTitle = element.find('.wizard-pf-step.active .wizard-pf-step-title').text();
194194
expect(selectedSectionTitle).toBe('Second Step');
195195
});
196196

0 commit comments

Comments
 (0)