-
Notifications
You must be signed in to change notification settings - Fork 34
Description
There are some unresolved areas of difference between Figma and the codebase that Kayla would love to have resolved. One example is the code message and code editor modal. In Figma, these are 1 single component. Kayla would expect these components to be identical in look and feel. In the codebase, we are using two different PatternFly components, one of which is largely based around a third-party Monaco editor. This is not currently themed using PatternFly, which makes it difficult to change to exactly match design parameters at present. We would also need to explore what customizations are possible to get more of a match to the design using the default PatternFly components.
These are some options provided by Kayla:

Note that the existing code editor/code message do not exhibit the "old" behavior in dark mode at present.
Kayla and team want to use CodeBlock for everything that doesn't require editing. CodeEditor may make more sense where editing is important.
See also #149 for some of the earlier problems.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status