Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Commit d36fa3f

Browse files
dtaylor113jeff-phillips-18
authored andcommitted
fix(pfFilter): Update filter dropdown to latest designs (#1137)
1 parent 1edaf31 commit d36fa3f

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

src/less/filter.less

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@
3232
.caret {
3333
font-style: normal;
3434
}
35+
&.filter-selected {
36+
font-style: normal;
37+
color: inherit;
38+
}
3539
}
3640
.filter-pf-active-label {
3741
margin-right: 5px;

src/sass/converted/patternfly/_filter.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@
3232
.caret {
3333
font-style: normal;
3434
}
35+
&.filter-selected {
36+
font-style: normal;
37+
color: inherit;
38+
}
3539
}
3640
.filter-pf-active-label {
3741
margin-right: 5px;

src/sass/converted/rcue/_filter.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@
3232
.caret {
3333
font-style: normal;
3434
}
35+
&.filter-selected {
36+
font-style: normal;
37+
color: inherit;
38+
}
3539
}
3640
.filter-pf-active-label {
3741
margin-right: 5px;

tests/pages/_includes/widgets/forms/filter.html

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ <h3>Select Filters</h3>
4949
<span class="caret"></span>
5050
</button>
5151
<ul role="menu" class="dropdown-menu" aria-labelledby="filterSelectMenu">
52-
<li><a href="#">Filter by Birth Month</a></li>
5352
<li><a role="menuitem" tabindex="-1" href="#">January</a></li>
5453
<li class="selected"><a role="menuitem" tabindex="-1" href="#">February</a></li>
5554
<li><a href="#">March</a></li>
@@ -90,25 +89,23 @@ <h3>Category Filters</h3>
9089
<div class="filter-pf-category-select">
9190
<div class="filter-pf-select">
9291
<div class="dropdown btn-group">
93-
<button type="button" class="filter-pf-select-dropdown dropdown-toggle btn btn-default" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
92+
<button type="button" class="filter-pf-select-dropdown filter-selected dropdown-toggle btn btn-default" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
9493
Subaru
9594
<span class="caret"></span>
9695
</button>
9796
<ul class="dropdown-menu">
98-
<li><a href="#">Filter by Car Make</a></li>
9997
<li class="selected"><a href="#">Subaru</a></li>
10098
<li><a href="#">Toyota</a></li>
10199
</ul>
102100
</div>
103101
</div>
104102
<div class="filter-pf-select">
105103
<div class="dropdown btn-group">
106-
<button type="button" class="filter-pf-category-select-value filter-pf-select-dropdown dropdown-toggle btn btn-default" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
104+
<button type="button" class="filter-pf-category-select-value filter-pf-select-dropdown filter-selected dropdown-toggle btn btn-default" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
107105
Crosstrek
108106
<span class="caret"></span>
109107
</button>
110108
<ul class="dropdown-menu">
111-
<li><a href="#">Filter by Car Model</a></li>
112109
<li><a href="#">Outback</a></li>
113110
<li><a href="#">Crosstrek</a></li>
114111
<li><a href="#">Impreza</a></li>

0 commit comments

Comments
 (0)