clean up PR for review

Author: kmcfaul

src/components/NavSection.tsx

@@ -23,7 +23,8 @@ export const NavSection = ({
   const isActive = sortedNavEntries.some((entry) => entry.id === activeItem)
 
   let navItems = sortedNavEntries
-  if (sectionId === 'components') {
+  if (sectionId === 'components') { 
+    // only display unique entry.data.id in the nav list if the section is components
     navItems = [
       ...sortedNavEntries
         .reduce((map, entry) => {

src/components/Navigation.tsx

@@ -13,7 +13,8 @@ export const Navigation: React.FunctionComponent<NavigationProps> = ({
   const [activeItem, setActiveItem] = useState('')
 
   useEffect(() => {
-    setActiveItem(window.location.pathname.split('/').reverse()[0]) // won't work with tabs
+    // TODO: Needs an alternate solution because of /tab in the path
+    setActiveItem(window.location.pathname.split('/').reverse()[0]) 
   }, [])
 
   const onNavSelect = (

src/content.config.ts

@@ -14,7 +14,7 @@ function defineContent(contentObj: CollectionDefinition) {
     return
   }
 
-  // Todo: expand for other packages that remain under the react umbrella (Table, CodeEditor, etc)
+  // TODO: Expand for other packages that remain under the react umbrella (Table, CodeEditor, etc)
   const tabMap: any = {
     'react-component-docs': 'react',
     'core-component-docs': 'html' 
@@ -27,8 +27,7 @@ function defineContent(contentObj: CollectionDefinition) {
       section: z.string(),
       subsection: z.string().optional(),
       title: z.string().optional(),
-      tab: z.string().optional().default(tabMap[name]),
-      // package: z.string().optional().default(packageName as string)
+      tab: z.string().optional().default(tabMap[name])
     }),
   })
 }

src/content.ts

@@ -1,13 +1,14 @@
 export const content = [
-  { base: 'textContent', pattern: '*.md', name: "textContent" }, 
-  {
-    "packageName":"@patternfly/react-core",
-    "pattern":"**/examples/**/*.md", // had to update the pattern to bring in demos docs
-    "name":"react-component-docs"
-  }, 
-  {
-    "packageName":"@patternfly/patternfly",
-    "pattern":"**/examples/**/*.md", // had to update the pattern to bring in demos docs
-    "name":"core-component-docs"
-  }
+  { base: 'textContent', pattern: '*.md', name: "textContent" } 
+  // TODO: Remove. Uncomment for local testing.
+  // {
+  //   "packageName":"@patternfly/react-core",
+  //   "pattern":"**/examples/**/*.md", // had to update this pattern to bring in demos docs
+  //   "name":"react-component-docs"
+  // }, 
+  // {
+  //   "packageName":"@patternfly/patternfly",
+  //   "pattern":"**/examples/**/*.md", // had to update this pattern to bring in demos docs
+  //   "name":"core-component-docs"
+  // }
 ]

src/globals.ts

@@ -1,6 +1,6 @@
 export const componentTabs: any = {};
 
-export const tabNameMapping: any = {
+export const tabNames: any = {
   'react': 'React',
   'react-demos': 'React demos',
   'react-deprecated': 'React deprecated',

src/pages/[section]/[page]/[...tab].astro

@@ -4,7 +4,7 @@ import { Title, PageSection, Content as PFContent } from '@patternfly/react-core
 import MainLayout from '../../../layouts/Main.astro'
 import { content } from "../../../content"
 import { kebabCase } from 'change-case'
-import { componentTabs, tabNameMapping } from '../../../globals';
+import { componentTabs, tabNames } from '../../../globals';
 
 export async function getStaticPaths() {
   const collections = await Promise.all(content.map(async (entry) => await getCollection(entry.name as 'textContent')))
@@ -91,7 +91,7 @@ const currentPath = Astro.url.pathname;
               class={`pf-v6-c-tabs__item${currentPath === `/${section}/${kebabCase(id)}/${tab}` ? ' pf-m-current' : ''}`}
             >
               <a class="pf-v6-c-tabs__link" href={`/${section}/${kebabCase(id)}/${tab}`}>
-                {tabNameMapping[tab]}
+                {tabNames[tab]}
               </a>
             </li>
           ))}