Skip to content

Commit d32e1d2

Browse files
author
Eric Olkowski
committed
Moved sidebar class logic out of function
1 parent 7b5b482 commit d32e1d2

File tree

1 file changed

+15
-19
lines changed

1 file changed

+15
-19
lines changed

src/components/PageToggle.tsx

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -18,28 +18,24 @@ export const PageToggle: React.FunctionComponent = () => {
1818
* Without it the page content will not expand to fill the space left by the sidebar when it is collapsed.
1919
*/
2020
// Possibly can refactor to remove applying classes when https://github.com/patternfly/patternfly/issues/7377 goes in
21-
function applySidebarStylesToIsland() {
22-
const isClientSide = typeof window !== 'undefined'
23-
const sideBarIsland =
24-
document.getElementById('page-sidebar-body')?.parentElement
21+
const isClientSide = typeof window !== 'undefined'
22+
const sideBarIsland =
23+
document.getElementById('page-sidebar-body')?.parentElement
2524

26-
if (!isClientSide || !sideBarIsland) {
27-
return
28-
}
29-
30-
if (!sideBarIsland.classList.contains(styles.pageSidebar)) {
31-
sideBarIsland.classList.add(
32-
styles.pageSidebar,
33-
$isNavOpen ? styles.modifiers.expanded : styles.modifiers.collapsed,
34-
)
35-
} else {
36-
sideBarIsland.classList.toggle(styles.modifiers.expanded)
37-
sideBarIsland.classList.toggle(styles.modifiers.collapsed)
38-
}
39-
sideBarIsland.setAttribute('aria-hidden', `${!$isNavOpen}`)
25+
if (!isClientSide || !sideBarIsland) {
26+
return
4027
}
4128

42-
applySidebarStylesToIsland()
29+
if (!sideBarIsland.classList.contains(styles.pageSidebar)) {
30+
sideBarIsland.classList.add(
31+
styles.pageSidebar,
32+
$isNavOpen ? styles.modifiers.expanded : styles.modifiers.collapsed,
33+
)
34+
} else {
35+
sideBarIsland.classList.toggle(styles.modifiers.expanded)
36+
sideBarIsland.classList.toggle(styles.modifiers.collapsed)
37+
}
38+
sideBarIsland.setAttribute('aria-hidden', `${!$isNavOpen}`)
4339
}, [$isNavOpen])
4440

4541
return (

0 commit comments

Comments
 (0)