Skip to content

Commit 0528246

Browse files
author
castastrophe
committed
Remove unnecessary comments
1 parent 7544220 commit 0528246

File tree

2 files changed

+10
-22
lines changed

2 files changed

+10
-22
lines changed

elements/pfe-accordion/src/pfe-accordion-header.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ $LOCAL: accordion;
1010
@include pfe-accordion-header;
1111

1212
button {
13-
@include pfe-trigger-button;
1413
@include pfe-trigger-color($component-name: accordion);
14+
@include pfe-trigger-button;
1515

1616
&[aria-expanded="true"] {
1717
@include pfe-trigger-color-expanded($component-name: accordion);

elements/pfe-sass/mixins/_mixins.scss

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ $pfe-expand_chevron--placement: #{$pfe-expand_button--LineHeight / 2 - $pfe
213213
}
214214
}
215215

216-
@mixin pfe-trigger-button($theme: light, $align: left) {
216+
@mixin pfe-trigger-button($align: left) {
217217
-webkit-appearance: button;
218218
margin: 0;
219219
width: 100%;
@@ -228,16 +228,16 @@ $pfe-expand_chevron--placement: #{$pfe-expand_button--LineHeight / 2 - $pfe
228228
font-size: calc(#{pfe-var(font-size)} * 1.1);
229229
line-height: #{pfe-var(line-height)};
230230

231-
color: #{pfe-local(aux)}; //var(--pfe-#{$component-name}--aux);
232-
background-color: #{pfe-local(main)}; //var(--pfe-#{$component-name}--main);
233-
border-left: #{pfe-local(BorderLeft)}; //var(--pfe-#{$component-name}--border-left);
234-
border-right: #{pfe-local(BorderRight)}; //var(--pfe-#{$component-name}--border-right);
235-
border-bottom: #{pfe-local(BorderBottom)}; //var(--pfe-#{$component-name}--border-bottom);
231+
color: #{pfe-local(aux)};
232+
background-color: #{pfe-local(main)};
233+
border-left: #{pfe-local(BorderLeft)};
234+
border-right: #{pfe-local(BorderRight)};
235+
border-bottom: #{pfe-local(BorderBottom)};
236236
border-top: 0;
237237

238238
&:hover {
239239
outline: none;
240-
border-left-color: #{pfe-local(BorderLeftColor--focus)}; //var(--pfe-#{$component-name}--focus);
240+
border-left-color: #{pfe-local(BorderLeftColor--focus)};
241241
z-index: 2;
242242
}
243243

@@ -265,23 +265,11 @@ $pfe-expand_chevron--placement: #{$pfe-expand_button--LineHeight / 2 - $pfe
265265
@mixin pfe-trigger-button-last($theme: light) {
266266
border-bottom: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border--lightest)};
267267
// @TODO Support differences based on theme
268-
// @if $theme == dark {
269-
// border-bottom: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border--lightest)};
270-
// }
271-
// @else {
272-
// border-bottom: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border--lightest)};
273-
// }
274268
}
275269

276270
@mixin pfe-trigger-button-first($theme: light) {
277271
border-top: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border--lightest)};
278272
// @TODO Support differences based on theme
279-
// @if $theme == dark {
280-
// border-top: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border--lightest)};
281-
// }
282-
// @else {
283-
// border-top: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border--lightest)};
284-
// }
285273
}
286274

287275
@mixin pfe-trigger-expanded {
@@ -294,17 +282,17 @@ $pfe-expand_chevron--placement: #{$pfe-expand_button--LineHeight / 2 - $pfe
294282
@if $theme == dark {
295283
--pfe-#{$component-name}--main: transparent;
296284
--pfe-#{$component-name}--aux: #{pfe-color(surface--darkest--text)};
297-
--pfe-#{$component-name}--BorderLeftColor--focus: #{pfe-color(surface--lightest)};
285+
--pfe-#{$component-name}--BorderLeftColor--focus: #{pfe-color(surface--lightest)};
298286
}
299287
@else {
300288
--pfe-#{$component-name}--main: transparent;
301289
--pfe-#{$component-name}--aux: #{pfe-color(surface--lightest--text)};
302290

303291
--pfe-#{$component-name}--BorderLeft: #{pfe-var(surface--border-width-heavy)} #{pfe-var(surface--border-style)} transparent;
304292
--pfe-#{$component-name}--BorderRight: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} transparent;
293+
--pfe-#{$component-name}--BorderBottom: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border--lightest)};
305294

306295
--pfe-#{$component-name}--BorderLeftColor--focus: #{pfe-color(surface--lightest--link)};
307-
--pfe-#{$component-name}--BorderBottom: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border--lightest)};
308296
}
309297
}
310298

0 commit comments

Comments
 (0)