fix: Accordion set to hidden when assigned to content set panel (#1238)

* test: Remove demo page from compiled assets

* test: Prettier + pre-build script

* test: Update content set bug and baselines

* fix: Revert demo listing changes

* fix: Update changelog

* fix: Add a test to ensure the nested tab/accordion isn't hidden

* fix: Swap to using a custom attribute instead of an id

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: castastrophe

CHANGELOG-1.x.md

@@ -1,3 +1,6 @@
+## 1.0.1 ( TBD )
+
+- [](https://github.com/patternfly/patternfly-elements/commit/) fix: Accordion assigned to content set panel was always being set to hidden
 ## 1.0.0 ( 2020-12-02 )
 
 - [e86f33e](https://github.com/patternfly/patternfly-elements/commit/e86f33e0342933f1992d52a022f9a25fd1e2fbeb) feat: Add standard attribute/property definitions 

elements/pfe-content-set/src/pfe-content-set.html

@@ -1,5 +1,5 @@
 <div id="lightdom" hidden>
   <slot></slot>
 </div>
-<pfe-tabs hidden></pfe-tabs>
-<pfe-accordion hidden></pfe-accordion>
+<pfe-tabs hidden visible-at="large"></pfe-tabs>
+<pfe-accordion hidden visible-at="small"></pfe-accordion>

elements/pfe-content-set/src/pfe-content-set.js

@@ -113,12 +113,12 @@ class PfeContentSet extends PFElement {
 
   get tab() {
     // Check if the appropriate tag exists already
-    return this.shadowRoot.querySelector(PfeTabs.tag);
+    return this.shadowRoot.querySelector(`${PfeTabs.tag}[visible-at="large"]`);
   }
 
   get accordion() {
     // Check if the appropriate tag exists already
-    return this.shadowRoot.querySelector(PfeAccordion.tag);
+    return this.shadowRoot.querySelector(`${PfeAccordion.tag}[visible-at="small"]`);
   }
 
   get displayTemplate() {

elements/pfe-content-set/test/pfe-content-set_test.js

@@ -149,6 +149,7 @@ suite('<pfe-content-set>', () => {
       assert.isNotNull(firstChild);
       assert.equal(firstChild.tagName, "PFE-TABS");
       assert.equal(pfeAccordion.tagName, "PFE-ACCORDION");
+      assert.isFalse(pfeAccordion.hasAttribute("hidden"));
     });
 
   test(
@@ -161,6 +162,7 @@ suite('<pfe-content-set>', () => {
       assert.isNotNull(firstChild);
       assert.equal(firstChild.tagName, "PFE-TABS");
       assert.equal(pfeTabs.tagName, "PFE-TABS");
+      assert.isFalse(pfeTabs.hasAttribute("hidden"));
     });
 
   test("it should set the correct \"on\" attribute from a parent component that has a color attribute",