Skip to content

Commit 07f8358

Browse files
authored
add debug logging flag (#198)
* add debug logging flag * adding attributeChangedCallback to test for logging tests
1 parent 2fbe786 commit 07f8358

File tree

15 files changed

+150
-18
lines changed

15 files changed

+150
-18
lines changed

elements/rh-number/rh-number.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

elements/rh-number/rh-number.js.map

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

elements/rh-number/rh-number.umd.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

elements/rh-number/rh-number.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

elements/rh-number/src/rh-number.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ class RhNumber extends RHElement {
6767
}
6868

6969
attributeChangedCallback(attr, oldVal, newVal) {
70+
super.attributeChangedCallback(...arguments);
7071
switch (attr) {
7172
case "type":
7273
this._determineFormat();

elements/rhelement/reveal.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,15 @@
2020
* SOFTWARE.
2121
*/
2222

23+
let logger = () => null;
24+
2325
export function reveal() {
24-
console.log(`[reveal] elements ready, revealing the body`);
26+
logger(`[reveal] elements ready, revealing the body`);
2527
window.document.body.removeAttribute("unresolved");
2628
}
2729

28-
export function autoReveal() {
30+
export function autoReveal(logFunction) {
31+
logger = logFunction;
2932
// If Web Components are already ready, run the handler right away. If they
3033
// are not yet ready, wait.
3134
//
@@ -42,6 +45,6 @@ export function autoReveal() {
4245
}
4346

4447
function handleWebComponentsReady() {
45-
console.log("[reveal] web components ready");
48+
logger("[reveal] web components ready");
4649
reveal();
4750
}

elements/rhelement/reveal.umd.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,15 @@
2020
* SOFTWARE.
2121
*/
2222

23+
let logger = () => null;
24+
2325
export function reveal() {
24-
console.log(`[reveal] elements ready, revealing the body`);
26+
logger(`[reveal] elements ready, revealing the body`);
2527
window.document.body.removeAttribute("unresolved");
2628
}
2729

28-
export function autoReveal() {
30+
export function autoReveal(logFunction) {
31+
logger = logFunction;
2932
// If Web Components are already ready, run the handler right away. If they
3033
// are not yet ready, wait.
3134
//
@@ -42,6 +45,6 @@ export function autoReveal() {
4245
}
4346

4447
function handleWebComponentsReady() {
45-
console.log("[reveal] web components ready");
48+
logger("[reveal] web components ready");
4649
reveal();
4750
}

elements/rhelement/rhelement.js

Lines changed: 18 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

elements/rhelement/rhelement.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)