adding a check in pfe-tab-panel to see if associated tab is selected when panel is initialized (#432)

kylebuch8 · web-flow · commit 1b92821de18f · 2019-06-24T09:03:54.000-04:00
* removing Promise.all since we're not using slotchange event Fixes #431 * adding the promises back in but leaving the previousElementSibling check in pfe-tab-panel Fixes #431 * added pfe-navigation tests by accident
diff --git a/elements/pfe-tabs/src/pfe-tabs.js b/elements/pfe-tabs/src/pfe-tabs.js
@@ -605,7 +605,9 @@ class PfeTabPanel extends PFElement {
       this.setAttribute("tabindex", 0);
     }
 
-    this.hidden = true;
+    if (this.previousElementSibling.getAttribute("aria-selected") !== "true") {
+      this.hidden = true;
+    }
 
     if (window.ShadyCSS) {
       this._observer.observe(this, { childList: true });

Original file line number	Diff line number	Diff line change
`@@ -605,7 +605,9 @@ class PfeTabPanel extends PFElement {`
`605`	`605`	`this.setAttribute("tabindex", 0);`
`606`	`606`	`}`
`607`	`607`
`608`		`- this.hidden = true;`
	`608`	`+ if (this.previousElementSibling.getAttribute("aria-selected") !== "true") {`
	`609`	`+ this.hidden = true;`
	`610`	`+ }`
`609`	`611`
`610`	`612`	`if (window.ShadyCSS) {`
`611`	`613`	`this._observer.observe(this, { childList: true });`