Commit 20bd14d
feat: add button variant to pfe-autocomplete (#1108)
* feat: pfe-button component
First pass at creating a button.
* pfe-button readme, story, tests, and JS updates
* adding code comments
* first attempt at styling
* Update elements/pfe-button/src/pfe-button.json
Co-authored-by: [ Cassondra ] <[email protected]>
* using denylistAttributes instead of blackListedAttributes
* adding a React demo page
* removing discovery and changelog documents
* style: 💄 add button line-height
* style: 💄 add button font-family
* refactor: 🎨 interpolate variables expressions
* refactor: 🎨 interpolate variables expressions
* feat: 💄 add additional border vars
* refactor: 🎨 interpolate, use new border vars, & cleanup
* style: 💄 add correct bg color for control disabled state
* refactor: 🎨 cleanup
* fix: 🐛 add submit and button types to demo; tweak input style
* feat: ✨ log click events in storybook
* feat: use pf theme colors
* using the pfe-var(line-height) variable
* updating text in pfe-button test
* Update pfe-button.scss
Stylesheet suggestions; simplified the interpolation and reduced unnecessary selectors
* Update pfe-button.scss
Moved after to a region
* fix: add custom click event to schema
* fix: hover property overrides for variants
* feat: add new variant to autocomplete
* feat: add default text to new button
* fix: need to select button starting with 'search-button'
* fix: need to set dropdwon in slot change handler
* feat: make demo page easier on the eyes
* feat: add textual button example
* fix: disabled styles need to apply outside of wrapper
* feat: add style hooks for the textual button
* fix: init autocomplete for new variant
* feat: print local vars
* feat: use pfe-button for external variant
* fix: no longer need this
* chore: cleanup
* refactor: abstract input init
* fix: import non-umd file of pfe-button
* feat: add new attr to json schema
* fix: pfe-btn import path
* docs: update readme & storybook knobs
* test: add test cases for textual btn
* feat: pfe-button component
First pass at creating a button.
* pfe-button readme, story, tests, and JS updates
* adding code comments
* first attempt at styling
* Update elements/pfe-button/src/pfe-button.json
Co-authored-by: [ Cassondra ] <[email protected]>
* using denylistAttributes instead of blackListedAttributes
* removing discovery and changelog documents
* style: 💄 add button line-height
* style: 💄 add button font-family
* refactor: 🎨 interpolate variables expressions
* refactor: 🎨 interpolate variables expressions
* feat: 💄 add additional border vars
* refactor: 🎨 interpolate, use new border vars, & cleanup
* style: 💄 add correct bg color for control disabled state
* refactor: 🎨 cleanup
* fix: 🐛 add submit and button types to demo; tweak input style
* feat: ✨ log click events in storybook
* feat: use pf theme colors
* using the pfe-var(line-height) variable
* updating text in pfe-button test
* Update pfe-button.scss
Stylesheet suggestions; simplified the interpolation and reduced unnecessary selectors
* Update pfe-button.scss
Moved after to a region
* fix: add custom click event to schema
* fix: hover property overrides for variants
* feat: add new variant to autocomplete
* feat: add default text to new button
* fix: need to select button starting with 'search-button'
* fix: need to set dropdwon in slot change handler
* feat: make demo page easier on the eyes
* feat: add textual button example
* fix: disabled styles need to apply outside of wrapper
* feat: add style hooks for the textual button
* fix: init autocomplete for new variant
* feat: print local vars
* feat: use pfe-button for external variant
* chore: cleanup
* refactor: abstract input init
* chore(deps-dev): bump @wdio/mocha-framework from 6.4.0 to 6.5.0 (#1129)
Bumps [@wdio/mocha-framework](https://github.com/webdriverio/webdriverio) from 6.4.0 to 6.5.0.
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/master/CHANGELOG.md)
- [Commits](webdriverio/webdriverio@v6.4.0...v6.5.0)
Signed-off-by: dependabot-preview[bot] <[email protected]>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: [ Cassondra ] <[email protected]>
* fix: import non-umd file of pfe-button
* feat: add new attr to json schema
* fix: pfe-btn import path
* docs: update readme & storybook knobs
* test: add test cases for textual btn
* chore: update changelog
* fix: lock file out of sync
* fix: lock file
* updating pfe-autocomplete baselines
* updating pfe-autocomplete baseline images
* trying to hide the webkit "X"
* refactor: padding already applied elsewhere
* Fix merge issue; update baselines
Co-authored-by: Kyle Buchanan <[email protected]>
Co-authored-by: [ Cassondra ] <[email protected]>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: [ Cassondra ] <[email protected]>1 parent dfbb971 commit 20bd14d
File tree
16 files changed
+635
-498
lines changed- .storybook
- elements
- pfe-autocomplete
- demo
- src
- test
- pfe-button
- src
- test
- test/vrt-baseline
- desktop_chrome
- desktop_ie
16 files changed
+635
-498
lines changedLarge diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | | - | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | | - | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | | - | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| |||
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
32 | | - | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| |||
77 | 79 | | |
78 | 80 | | |
79 | 81 | | |
80 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
81 | 86 | | |
82 | | - | |
| 87 | + | |
83 | 88 | | |
84 | 89 | | |
85 | 90 | | |
| |||
89 | 94 | | |
90 | 95 | | |
91 | 96 | | |
92 | | - | |
93 | 97 | | |
94 | | - | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
95 | 101 | | |
96 | 102 | | |
97 | 103 | | |
98 | 104 | | |
99 | 105 | | |
100 | 106 | | |
| 107 | + | |
101 | 108 | | |
102 | 109 | | |
103 | | - | |
| 110 | + | |
104 | 111 | | |
105 | 112 | | |
106 | 113 | | |
107 | 114 | | |
108 | 115 | | |
109 | 116 | | |
110 | | - | |
| 117 | + | |
| 118 | + | |
111 | 119 | | |
112 | 120 | | |
113 | 121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | 9 | | |
12 | 10 | | |
13 | 11 | | |
| |||
40 | 38 | | |
41 | 39 | | |
42 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
43 | 49 | | |
44 | 50 | | |
45 | 51 | | |
46 | 52 | | |
47 | 53 | | |
48 | | - | |
| 54 | + | |
49 | 55 | | |
50 | 56 | | |
51 | 57 | | |
| |||
71 | 77 | | |
72 | 78 | | |
73 | 79 | | |
74 | | - | |
| 80 | + | |
| 81 | + | |
75 | 82 | | |
76 | 83 | | |
77 | 84 | | |
| |||
91 | 98 | | |
92 | 99 | | |
93 | 100 | | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
100 | 108 | | |
101 | | - | |
102 | | - | |
103 | | - | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
104 | 113 | | |
105 | 114 | | |
106 | 115 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | | - | |
8 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
9 | 11 | | |
10 | | - | |
11 | | - | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
22 | 19 | | |
23 | 20 | | |
24 | 21 | | |
| |||
36 | 33 | | |
37 | 34 | | |
38 | 35 | | |
39 | | - | |
| 36 | + | |
40 | 37 | | |
41 | 38 | | |
| 39 | + | |
| 40 | + | |
42 | 41 | | |
43 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
0 commit comments