Skip to content

Commit 2ba0b43

Browse files
anujsinglaanujsibennypowers
authored
fix(popover): add outsideClick event on popover show (#2514)
* fix(popover): add outsideClick event on popover show * docs: create perfect-rockets-approve.md --------- Co-authored-by: Anuj Singla <[email protected]> Co-authored-by: Benny Powers <[email protected]>
1 parent 78f3333 commit 2ba0b43

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@patternfly/elements": patch
3+
---
4+
5+
`<pf-popover>`: prevent memory leak by removing event listeners event on popover close

elements/pf-popover/pf-popover.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,6 @@ export class PfPopover extends LitElement {
321321
connectedCallback() {
322322
super.connectedCallback();
323323
this.addEventListener('keydown', this.onKeydown);
324-
PfPopover.instances.add(this);
325324
}
326325

327326
render() {
@@ -454,6 +453,7 @@ export class PfPopover extends LitElement {
454453
});
455454
this._popover?.show();
456455
this.dispatchEvent(new PopoverShownEvent());
456+
PfPopover.instances.add(this);
457457
}
458458

459459
/**
@@ -464,6 +464,7 @@ export class PfPopover extends LitElement {
464464
await this.#float.hide();
465465
this._popover?.close();
466466
this.dispatchEvent(new PopoverHiddenEvent());
467+
PfPopover.instances.delete(this);
467468
}
468469
}
469470

0 commit comments

Comments
 (0)