fix(tabs): fix focus on keyboard navigation for safari (#2485)

* fix(tabs): removes call to RTI updateActiveItem on tab expand

* chore(tabs): add changeset

* fix(tabs): update activeItem if its not equal the the event tab

* fix(tabs): apply focus to tab on click for safari

* chore(tabs): update changeset

* fix(tabs): return ids to tabs and panels

* fix(tabs): remove id from tab and panel

* fix(tabs): remove randomId import

* fix(tabs): override focus and apply to shadowroot button

* fix(tabs): override focus and apply to shadowroot button

* chore(tabs): update changeset

* chore(tabs): update changeset

Author: zeroedin

.changeset/perfect-dragons-double.md

@@ -0,0 +1,7 @@
+---
+"@patternfly/elements": patch
+---
+
+`BaseTab`: 
+ - fixed Safari focus issue on keyboard navigation
+ - fixed Safari focus issue on mouse click

elements/pf-tabs/BaseTab.ts

@@ -63,9 +63,14 @@ export abstract class BaseTab extends LitElement {
     }
   }
 
+  focus() {
+    this.button.focus();
+  }
+
   #clickHandler() {
     if (!this.disabled && this.#internals.ariaDisabled !== 'true' && this.ariaDisabled !== 'true') {
       this.active = true;
+      this.focus(); // safari fix
     }
   }
 

elements/pf-tabs/BaseTabs.ts

@@ -226,8 +226,10 @@ export abstract class BaseTabs extends LitElement {
     }
 
     if (event.active) {
+      if (event.tab !== this.#tabindex.activeItem) {
+        this.#tabindex.updateActiveItem(event.tab);
+      }
       this.activeIndex = this.#allTabs.findIndex(tab => tab === event.tab);
-      this.#tabindex.updateActiveItem(this.#activeTab);
     }
   };