Skip to content

Commit 36bbb25

Browse files
committed
US206196 code review changes
- fixed right margins on narrower breakpoints - added border-box to __content region
1 parent 95d3905 commit 36bbb25

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

elements/pfe-modal/src/pfe-modal.scss

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ $pfe-modal--breakpoint--medium: 640px;
5353
position: relative;
5454
max-width: pfe-local(MaxWidth--mobile);
5555
min-width: pfe-local(MinWidth);
56-
max-height: calc(100% + -32px);
56+
max-height: pfe-local(MaxHeight);
5757
margin: 0 auto;
5858
box-shadow: pfe-var(box-shadow--lg);
5959
background-color: pfe-color(surface--lightest);
@@ -77,14 +77,9 @@ $pfe-modal--breakpoint--medium: 640px;
7777
overscroll-behavior: contain;
7878
max-height: pfe-local(MaxHeight);
7979
padding: pfe-local(Padding);
80+
box-sizing: border-box;
8081

8182
@media screen and (max-height: $pfe-modal--breakpoint--medium) {
82-
box-sizing: border-box;
83-
--pfe-modal--Padding: #{pfe-var(container-padding)} calc(#{pfe-var(container-padding)} * 2) #{pfe-var(container-padding)} #{pfe-var(container-padding)};
84-
}
85-
86-
@media screen and (max-height: $pfe-modal--breakpoint--medium) and (min-width: $pfe-modal--breakpoint--medium) {
87-
box-sizing: border-box;
8883
--pfe-modal--Padding: #{pfe-var(container-padding)} calc(#{pfe-var(container-padding)} * 3) #{pfe-var(container-padding)} #{pfe-var(container-padding)};
8984
}
9085

0 commit comments

Comments
 (0)