Skip to content

Commit 3d3c4f1

Browse files
authored
Fix content-set + accordion bug (#1742)
1 parent f378caa commit 3d3c4f1

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

CHANGELOG-1.x.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfe-autocomplete update aria-selected attribute
44
- [d3ea7fa](https://github.com/patternfly/patternfly-elements/commit/d3ea7facb0c36b7f3e20e2568bdc4bf2e5a5a852) feat: Graceful failure for component registry
5-
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: container sass placeholder using incorrect variable for spacing (#1522)
65
- [099dc3e](https://github.com/patternfly/patternfly-elements/commit/099dc3e2d3ce732a32ecde0644f5c03ec1e8dd9c) fix: Accordion alignment with latest design kit
76
- [5f88c39](https://github.com/patternfly/patternfly-elements/commit/5f88c3963f8a6c13a9aeba6e9f664678453d46ce) fix: Jump links parseInt for IE11
7+
- [43a904e](https://github.com/patternfly/patternfly-elements/commit/43a904e2ce4f2ef7182f803bf35ade463e7c2f1d) fix: container sass placeholder using incorrect variable for spacing (#1522)
8+
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: accordion rendering slotted content in the header
89

910
# 1.10.1 (2021-07-12)
1011

elements/pfe-accordion/src/pfe-accordion-header.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,10 @@ class PfeAccordionHeader extends PFElement {
196196
// Capture it's assigned nodes for validation
197197
let slotted = node.assignedNodes();
198198
// If slotted elements were found, add it to the nodeList
199-
if (slotted && slotted.length > 0) nodes[idx] = slotted;
200-
else {
199+
if (slotted && slotted.length > 0) {
200+
// Remove the slot from the set, add the slotted content
201+
nodes.splice(idx, 1, ...slotted);
202+
} else {
201203
// If no content exists in the slot, check for default content in the slot template
202204
const defaults = node.children;
203205
if (defaults && defaults.length > 0) nodes[idx] = defaults[0];

0 commit comments

Comments
 (0)