Skip to content

Commit 40e0b09

Browse files
starryeyez024castastrophegithub-actions[bot]kylebuch8[ Cassondra ]
authored
fix: saturated visited link color (#1127)
* Fix saturated visited link color * Update _colors.scss * add changelog * Add visited links to demo page for AT * Fix visited link logic; can't point to your localhost path because it's relative to system * Update changelog and baselines Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kyle Buchanan <[email protected]> Co-authored-by: [ Cassondra ] <[email protected]>
1 parent bad59ed commit 40e0b09

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

CHANGELOG-1.x.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@
1010
- [f5443c5](https://github.com/patternfly/patternfly-elements/commit/f5443c58a543368ca58bb98498452af6e4fd88bc) fix: Add a build step to the release script (#1062)
1111
- [b32b41c](https://github.com/patternfly/patternfly-elements/commit/b32b41c2071eb59c5fc17b6c233783cacea59b92) fix: pfe-accordion adding right border and shadow back (#1184)
1212
- [47a1f4f](https://github.com/patternfly/patternfly-elements/commit/47a1f4fe9365f9366974fe67a30b48cc91e4e6a8) fix: unwanted padding on pfe-accordion (#1083)
13-
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfe-tabs vertical display on mobile
14-
- []() fix: umd.min modules now import umd.min builds of PFE dependencies (#1168)
13+
- [e3cc73b](https://github.com/patternfly/patternfly-elements/commit/e3cc73b92d06cdf7fef8dc091733a046a14e12e5) fix: pfe-tabs vertical display on mobile (#1135)
14+
- [6eadb21](https://github.com/patternfly/patternfly-elements/commit/6eadb21a29768c06ff312de42bd54b44072ee051) fix: umd.min modules now import umd.min builds of PFE dependencies (#1168)
15+
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: global theme palette color for visited links in a saturated context

elements/pfe-card/demo/index.html

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ <h1>&lt;pfe-card&gt;</h1>
5656

5757
<pfe-card color="lightest" pfe-border>
5858
<h2 slot="pfe-card--header">Lightest card</h2>
59-
<p>This is the lightest pfe-card and <a href="#">a link</a> with <code>pfe-border</code>.</p>
59+
<p>This is the lightest pfe-card and <a href="#">a link</a>, and <a href=".">a visited link</a> with
60+
<code>pfe-border</code>.</p>
6061
<div class="button-series" slot="pfe-card--footer">
6162
<pfe-cta slot="pfe-card--footer" priority="secondary">
6263
<a href="#">Try</a>
@@ -69,7 +70,7 @@ <h2 slot="pfe-card--header">Lightest card</h2>
6970

7071
<pfe-card color="lighter">
7172
<h2 slot="pfe-card--header">Lighter card (deprecated)</h2>
72-
<p>This is the lightest pfe-card and <a href="#">a link</a>.</p>
73+
<p>This is the lightest pfe-card and <a href="#">a link</a>, and <a href=".">a visited link</a>.</p>
7374
<div class="button-series" slot="pfe-card--footer">
7475
<pfe-cta slot="pfe-card--footer" priority="secondary">
7576
<a href="#">Try</a>
@@ -82,7 +83,7 @@ <h2 slot="pfe-card--header">Lighter card (deprecated)</h2>
8283

8384
<pfe-card>
8485
<h2 slot="pfe-card--header">Default card</h2>
85-
Unwrapped item. This is the default pfe-card and <a href="#">a link</a>.
86+
Unwrapped item. This is the default pfe-card and <a href=#"">a link</a>, and <a href=".">a visited link</a>.
8687
<div class="button-series" slot="pfe-card--footer">
8788
<pfe-cta slot="pfe-card--footer" priority="secondary">
8889
<a href="#">Try</a>
@@ -95,7 +96,7 @@ <h2 slot="pfe-card--header">Default card</h2>
9596

9697
<pfe-card color="darker">
9798
<h2 slot="pfe-card--header">Darker Card</h2>
98-
<p>This is the darker pfe-card and <a href="#">a link</a>.</p>
99+
<p>This is the darker pfe-card and <a href="#">a link</a>, and <a href=".">a visited link</a>.</p>
99100
<div class="button-series" slot="pfe-card--footer">
100101
<pfe-cta slot="pfe-card--footer" priority="secondary">
101102
<a href="#">Try</a>
@@ -108,23 +109,23 @@ <h2 slot="pfe-card--header">Darker Card</h2>
108109

109110
<pfe-card color="darkest">
110111
<h2 slot="pfe-card--header">Darkest Card</h2>
111-
<p>This is the darkest pfe-card and <a href="#">a link</a>.</p>
112+
<p>This is the darkest pfe-card and <a href="#">a link</a>, and <a href=".">a visited link</a>.</p>
112113
<pfe-cta slot="pfe-card--footer">
113114
<a href="#">Learn more</a>
114115
</pfe-cta>
115116
</pfe-card>
116117

117118
<pfe-card color="complement">
118119
<h2 slot="pfe-card--header">Complement Card</h2>
119-
<p>This is the complement pfe-card and <a href="#">a link</a>.</p>
120+
<p>This is the complement pfe-card and <a href="#">a link</a>, and <a href=".">a visited link</a>.</p>
120121
<pfe-cta slot="pfe-card--footer">
121122
<a href="#">Learn more</a>
122123
</pfe-cta>
123124
</pfe-card>
124125

125126
<pfe-card color="accent">
126127
<h2 slot="pfe-card--header">Accent Card</h2>
127-
<p>This is the accent pfe-card and <a href="#">a link</a>.</p>
128+
<p>This is the accent pfe-card and <a href="#">a link</a>, and <a href=".">a visited link</a>.</p>
128129
<pfe-cta slot="pfe-card--footer">
129130
<a href="#">Learn more</a>
130131
</pfe-cta>

elements/pfe-sass/maps/_colors.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ $pfe-colors: (
2323
text--on-saturated: $pf-color-white,
2424
text--muted--on-saturated: $pf-color-black-300,
2525
link--on-saturated: $pf-color-white,
26-
link--visited--on-saturated: $pf-color-purple-400,
26+
link--visited--on-saturated: $pf-color-black-300,
2727
link--hover--on-saturated: $pf-color-black-100,
2828
link--focus--on-saturated: $pf-color-black-100,
2929

15.3 KB
Loading
10.1 KB
Loading

0 commit comments

Comments
 (0)