fix(core): make internals controller ssrable

bennypowers · bennypowers · commit 43b97bf585dc · 2024-08-26T17:45:27.000+03:00
safari detector (predictably) breaks everyone else
diff --git a/.changeset/thin-aliens-smoke.md b/.changeset/thin-aliens-smoke.md
@@ -0,0 +1,4 @@
+---
+"@patternfly/pfe-core": patch
+---
+`InternalsController`: prevent Safari-detector from breaking SSR
diff --git a/core/pfe-core/controllers/internals-controller.ts b/core/pfe-core/controllers/internals-controller.ts
@@ -83,7 +83,8 @@ export class InternalsController implements ReactiveController, ARIAMixin {
     return Array.from(this.instances.get(host)?.internals.labels ?? []) as Element[];
   }
 
-  public static isSafari: boolean = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
+  public static isSafari: boolean =
+    !isServer && /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
 
   public static of(
     host: ReactiveControllerHost,

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +"@patternfly/pfe-core": patch
 +---
 +`InternalsController`: prevent Safari-detector from breaking SSR
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,8 @@ export class InternalsController implements ReactiveController, ARIAMixin {`
`83`	`83`	`return Array.from(this.instances.get(host)?.internals.labels ?? []) as Element[];`
`84`	`84`	`}`
`85`	`85`
`86`		`- public static isSafari: boolean = /^((?!chrome\|android).)*safari/i.test(navigator.userAgent);`
	`86`	`+ public static isSafari: boolean =`
	`87`	`+ !isServer && /^((?!chrome\|android).)*safari/i.test(navigator.userAgent);`
`87`	`88`
`88`	`89`	`public static of(`
`89`	`90`	`host: ReactiveControllerHost,`