Skip to content

Commit 43d91b6

Browse files
committed
docs: improve logo placement for mobile
1 parent de59e73 commit 43d91b6

File tree

3 files changed

+55
-19
lines changed

3 files changed

+55
-19
lines changed

docs/_includes/_nav.njk

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,15 @@
22
<div class="header-bar">
33
{% include "../_snippets/pf-bar-html.md" %}
44
<div class="logo-bar">
5-
<a href="{{ '/' | url }}" aria-label="PatternFly Elements Home">
6-
<img src="{{ '/images/pfe-logo-inverse-white.svg' | url }}" alt="PatternFly Elements">
7-
</a>
5+
<div class="logo-flex-wrap">
6+
<div class="placeholder"></div>
7+
<a href="{{ '/' | url }}" aria-label="PatternFly Elements Home">
8+
<picture>
9+
<source media="(min-width: 420px)" srcset="{{ '/images/pfe-logo-inverse-white.svg' | url }}">
10+
<img alt="PatternFly Elements" src="{{ '/images/pfe-logo-icon-white.svg' | url }}">
11+
</picture>
12+
</a>
13+
</div>
814
{# TODO: implement pf-dropdown
915
<pf-dropdown id="docs-versions-dropdown" aria-label="Docs Versions" label="Docs Versions">
1016
{% for version in versions %}
@@ -47,15 +53,12 @@
4753
</div>
4854
</div>
4955

50-
<input id="mobile-menu-toggle" class="menu-toggle element-invisible" type="checkbox"
51-
aria-controls="mobile-menu-menu-container" autocomplete="off">
52-
56+
<input id="mobile-menu-toggle" class="menu-toggle element-invisible" type="checkbox" aria-controls="mobile-menu-menu-container" autocomplete="off">
5357
<label class="menu-toggle__button l-header__mobile-menu-toggle" for="mobile-menu-toggle"
5458
data-controls="mobile-menu-menu-container">
5559
<span class="l-header__burger-icon"></span>
5660
<span class="menu-toggle-assistive-text element-invisible">Toggle menu visibility</span>
57-
</label>
58-
61+
</label>
5962
<div class="menu-toggle__toggleable site-navigation__outer-wrapper">
6063
<nav class="l-header__site-navigation site-navigation menu-toggle__toggleable-content-wrapper">
6164
<ul class="site-navigation__wrapper">
Lines changed: 15 additions & 0 deletions
Loading

docs/main.css

Lines changed: 29 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -361,12 +361,10 @@ main.blog {
361361
translate: 6px;
362362
}
363363

364-
365364
.logo-bar {
366-
--pf-navigation--Height--actual: 70px;
367365
display: flex;
366+
--pf-navigation--Height--actual: 70px;
368367
align-items: center;
369-
gap: 1em;
370368
height: 4.375rem; /* old: 3.75rem */
371369
padding-inline-start: var(--pf-c-masthead--PaddingLeft, var(--pf-c-masthead--inset, 24px));
372370
padding-inline-end: var(--pf-c-masthead--PaddingRight, var(--pf-c-masthead--inset, 24px));
@@ -376,19 +374,32 @@ main.blog {
376374
background: var(--pf-theme--color--accent, #0066cc);
377375
}
378376

379-
.logo-bar > a {
377+
.logo-flex-wrap {
378+
display: flex;
379+
gap: 1em;
380+
width: 100%;
381+
height: 100%;
382+
}
383+
384+
.logo-flex-wrap > .placeholder {
385+
/* 25px is the width of the hamburger */
386+
width: 25px;
387+
height: 57px;
388+
}
389+
390+
.logo-flex-wrap > a {
380391
display: flex;
381392
align-items: center;
382393
color: white;
383394
text-decoration: none;
384395
font-size: 1.25rem;
385396
font-weight: bold;
386-
margin-left: calc(1.5rem + 16px);
387-
height: 100%;
397+
gap: 1rem;
388398
}
389399

390-
.logo-bar > a img {
391-
display: none;
400+
.logo-flex-wrap > a > picture,
401+
.logo-flex-wrap > a > picture > img {
402+
width: 100%;
392403
height: 100%;
393404
}
394405

@@ -472,7 +483,6 @@ main.blog {
472483
.l-header__mobile-menu-toggle {
473484
width: 1.5rem;
474485
height: 4.375rem;
475-
margin-right: 16px;
476486
color: #fff;
477487
z-index: 200;
478488
position: fixed;
@@ -816,6 +826,14 @@ blockquote {
816826
padding-inline: var(--pf-global--spacer--3xl, 4rem)
817827
}
818828

829+
.logo-flex-wrap {
830+
gap: 0;
831+
}
832+
833+
.logo-flex-wrap .placeholder:empty {
834+
display: none;
835+
}
836+
819837
#component-list {
820838
padding: var(--pf-global--spacer--3xl, 4rem) var(--pf-global--spacer--3xl, 4rem);
821839
}
@@ -842,11 +860,11 @@ blockquote {
842860
top: 2rem;
843861
}
844862

845-
.logo-bar > a {
863+
.logo-flex-wrap > a {
846864
margin-left: 16px;
847865
}
848866

849-
.logo-bar > a img {
867+
.logo-flex-wrap > a > picture > img {
850868
display: inline-block;
851869
position: relative;
852870
left: -1rem;

0 commit comments

Comments
 (0)