chore: update dependencies (#2475)

* chore: update dependencies

* chore: update ts config for v5

* chore: update deps

* chore: update deps

* chore: replace ttypescript with ts-patch beta

* fix: appease typescript

* fix: align typescript versions

* style: workaround chai-semantic-dom-diff lint error

* test: fix test runner tsconfig settings

* feat(tools): allUpdates test helper

* test: use allUpdates helper

Author: bennypowers

.changeset/test-helper-allupdates.md

@@ -0,0 +1,10 @@
+---
+"@patternfly/pfe-tools": minor
+---
+**Test Helpers**: Added `allUpdates` test helper, which waits until an element 
+completely finishes updating.
+
+```js
+const element = await fixture(html`<my-el></my-el>`);
+await allUpdates(element);
+```

.github/workflows/commitlint.yml

@@ -30,6 +30,9 @@ jobs:
         with:
           fetch-depth: 0
 
+      # https://github.com/wagoid/commitlint-github-action/issues/560#issuecomment-1277659864
+      - run: rm tsconfig.json
+
       - uses: wagoid/commitlint-github-action@v5
         id: commitlint
         continue-on-error: true
@@ -58,48 +61,8 @@ jobs:
           script: |
             const results = ${{ steps.commitlint.outputs.results }};
             const titleGood = ${{ steps.prTitle.outputs.success }};
-
-            const totalErrors = results.reduce((a, r) => a + r.errors.length, 0);
-            const totalWarnings = results.reduce((a, r) => a + r.warnings.length, 0);
-
-            const header = `
-            ## 👕 Commitlint Problems for this PR: ${!titleGood ? '' : `
-
-            **The PR title conforms to conventional commit style**
-
-            👉 **Make sure the PR is squashed into a single commit using the PR title** 👈`}
-
-            🔎   found ${totalErrors} errors, ${totalWarnings} warnings
-            ℹ️   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
-            `;
-
-            const comment = results.reduce((acc, result) => {
-              if (!result.errors.length && !result.warnings.length) {
-                return acc;
-              }
-
-              const [firstLine, ...rest] = result.message.split('\n');
-
-              const body = rest.join('\n').trim();
-              const icon = result.errors.length ? '❌' : '⚠️';
-              const hash = result.hash.substring(0, 8);
-
-              return `${acc} ${!body.length ? '\n\n' : `
-
-            <details><summary>`}
-            ${hash} - ${firstLine} ${!body.length ? '\n\n' : `\
-            </summary>
-
-            ${body}
-
-            </details>
-
-            `}${result.errors.map(error => `
-            - ❌ ${error}`).join('')} ${result.warnings.map(warn => `
-            - ⚠️ ${warn}`).join('')}`;
-            }, header);
-
-            core.setOutput('comment', comment);
+            const { format } = await import('${{ github.workspace }}/scripts/format-commitlint-messages.js');
+            return format({ core, results, titleGood });
 
       - name: Notify PR
         if: ${{ steps.commitlint.outcome == 'failure' && steps.prTitle.outputs.success == 'false' }}
@@ -109,7 +72,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           header: commitlint
           message: |
-            ${{ steps.format.outputs.comment }}
+            ${{ steps.format.outputs.result }}
 
       - name: Fail Job on Error
         if: ${{ steps.commitlint.outcome == 'failure' && steps.prTitle.outputs.success == 'false' }}

.github/workflows/tests.yml

@@ -79,8 +79,10 @@ jobs:
     strategy:
       matrix:
         node:
-          - 18
-          - 19
+          - '18'
+          - '19'
+          # https://github.com/TypeStrong/ts-node/issues/1997
+          # - '20'
     if: |
       github.event_name == 'workflow_dispatch'
       ||   github.event_name == 'push'

core/pfe-core/controllers/floating-dom-controller.ts

@@ -3,8 +3,7 @@ import type { ReactiveController, ReactiveElement } from 'lit';
 import type { StyleInfo } from 'lit/directives/style-map.js';
 import type { Options as Offset } from '@floating-ui/core/src/middleware/offset';
 
-
-export { Placement };
+export type { Placement };
 
 import {
   autoUpdate,

core/pfe-core/controllers/internals-controller.ts

@@ -12,7 +12,7 @@ export class InternalsController implements ReactiveController, ARIAMixin {
   declare ariaChecked: ARIAMixin['ariaChecked'];
   declare ariaColCount: ARIAMixin['ariaColCount'];
   declare ariaColIndex: ARIAMixin['ariaColIndex'];
-  declare ariaColIndexText: ARIAMixin['ariaColIndexText'];
+  declare ariaColIndexText: string | null;
   declare ariaColSpan: ARIAMixin['ariaColSpan'];
   declare ariaCurrent: ARIAMixin['ariaCurrent'];
   declare ariaDisabled: ARIAMixin['ariaDisabled'];
@@ -36,7 +36,7 @@ export class InternalsController implements ReactiveController, ARIAMixin {
   declare ariaRoleDescription: ARIAMixin['ariaRoleDescription'];
   declare ariaRowCount: ARIAMixin['ariaRowCount'];
   declare ariaRowIndex: ARIAMixin['ariaRowIndex'];
-  declare ariaRowIndexText: ARIAMixin['ariaRowIndexText'];
+  declare ariaRowIndexText: string | null;
   declare ariaRowSpan: ARIAMixin['ariaRowSpan'];
   declare ariaSelected: ARIAMixin['ariaSelected'];
   declare ariaSetSize: ARIAMixin['ariaSetSize'];

core/pfe-core/package.json

@@ -50,8 +50,8 @@
     "test": "wtr --files './test/*.spec.ts' --config ../../web-test-runner.config.js"
   },
   "dependencies": {
-    "@floating-ui/dom": "^1.2.3",
-    "lit": "2.6.1"
+    "@floating-ui/dom": "^1.2.6",
+    "lit": "^2.7.2"
   },
   "repository": {
     "type": "git",

elements/package.json

@@ -68,7 +68,7 @@
   },
   "wireit": {
     "build": {
-      "command": "ttsc -b . --pretty",
+      "command": "tspc -b . --pretty",
       "dependencies": [
         "analyze"
       ]

elements/pf-accordion/test/pf-accordion.spec.ts

@@ -10,17 +10,7 @@ import { PfAccordion, PfAccordionPanel, PfAccordionHeader } from '@patternfly/el
 import { Logger } from '@patternfly/pfe-core/controllers/logger.js';
 
 import '@patternfly/pfe-tools/test/stub-logger.js';
-
-async function allUpdates(element: ReactiveElement) {
-  let count = 0;
-  do {
-    if (count > 100) {
-      throw new Error('Too Many Updates');
-    }
-    await element.updateComplete;
-    count++;
-  } while (!await element.updateComplete);
-}
+import { allUpdates } from '@patternfly/pfe-tools/test/utils.js';
 
 describe('<pf-accordion>', function() {
   let element: PfAccordion;
@@ -1019,7 +1009,7 @@ describe('<pf-accordion>', function() {
               <pf-accordion-panel id="panel-2-2" data-index="1-1"></pf-accordion-panel>
             </pf-accordion>
           </pf-accordion-panel>
-        
+
           <pf-accordion-header id="header-3" data-index="2"></pf-accordion-header>
           <pf-accordion-panel id="panel-3" data-index="2"></pf-accordion-panel>
         </pf-accordion>

elements/pf-card/test/pf-card.spec.ts

@@ -137,7 +137,7 @@ describe('<pf-card>', function() {
 
     describe('accessible', function() {
       it('should be accessible in both the light and shadow dom', async function() {
-        expect(element).to.be.accessible();
+        await expect(element).to.be.accessible();
       });
       // TODO: this has been flaky. revisit later
       // it('should have an article element wrapper in the shadow dom', async function() {

elements/pf-jump-links/test/pf-jump-links.spec.ts

@@ -3,22 +3,12 @@ import { expect, html, nextFrame } from '@open-wc/testing';
 import { createFixture } from '@patternfly/pfe-tools/test/create-fixture.js';
 import { sendKeys } from '@web/test-runner-commands';
 
-import { PfJumpLinks } from '@patternfly/elements/pf-jump-links/pf-jump-links.js';
+import { PfJumpLinks } from '../pf-jump-links.js';
 import { PfJumpLinksItem } from '../pf-jump-links-item.js';
 import { PfJumpLinksList } from '../pf-jump-links-list.js';
 
 import '@patternfly/pfe-tools/test/stub-logger.js';
-
-async function allUpdates(element: ReactiveElement) {
-  let count = 0;
-  do {
-    if (count > 100) {
-      throw new Error('Too Many Updates');
-    }
-    await element.updateComplete;
-    count++;
-  } while (!await element.updateComplete);
-}
+import { allUpdates } from '@patternfly/pfe-tools/test/utils.js';
 
 describe('<pf-jump-links>', function() {
   let element: PfJumpLinks;