Skip to content

Commit 490ad8f

Browse files
committed
added some fixes to get tests to pass
1 parent 5d99125 commit 490ad8f

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

elements/pfe-autocomplete/src/pfe-autocomplete.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ class PfeAutocomplete extends PFElement {
262262
this._searchBtn.setAttribute("disabled", "");
263263
this._searchBtnTextual.setAttribute("disabled", "");
264264
this._input.focus();
265-
this._searchCleared();
265+
this._searchCleared(this._input.value);
266266
}
267267

268268
_search() {
@@ -275,12 +275,12 @@ class PfeAutocomplete extends PFElement {
275275
this._input.setAttribute("aria-expanded", "false");
276276
}
277277

278-
_searchCleared() {
279-
if (this._input.value == "") {
280-
this.emitEvent(PfeAutocomplete.events.optionsShown, {
278+
_searchCleared(searchQuery = '') {
279+
if (this._input.value === "") {
280+
this.emitEvent(PfeAutocomplete.events.optionCleared, {
281281
bubbles: true,
282282
composed: true,
283-
detail: { searchValue: searchQuery },
283+
detail: { searchValue: searchQuery},
284284
});
285285
}
286286
}

elements/pfe-autocomplete/test/pfe-autocomplete_test.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -181,17 +181,18 @@ describe('<pfe-autocomplete>', () => {
181181
flush(() => {
182182
const items = ['option 1', 'option 2'];
183183

184-
// autocompleteElem.autocompleteRequest = function (params, callback) {
185-
// const regx = new RegExp("\^" + params.query, "i");
186-
// callback(items.filter(function (item) {
187-
// return regx.test(item);
188-
// }));
189-
// };
184+
autocompleteElem.autocompleteRequest = function (params, callback) {
185+
const regx = new RegExp("\^" + params.query, "i");
186+
callback(items.filter(function (item) {
187+
return regx.test(item);
188+
}));
189+
};
190190

191191
autocompleteElem.addEventListener("pfe-autocomplete:option-cleared", function (event) {
192192
assert.isTrue(true); // the event listener was called
193193
done();
194194
});
195+
autocompleteElem._clear();
195196
});
196197
});
197198

0 commit comments

Comments
 (0)