fix: pfelement - restore pfelement tests (#1018)

* fix: improve CLS rating in lighthouse

* test(pfelement): restore pfelement tests, as they were not running

* changelog updates for pfelement

Co-authored-by: Kyle Buchanan <[email protected]>

Author: mwcz

CHANGELOG-prerelease.md

@@ -1,7 +1,7 @@
 ## Prerelease 55 ( TBD )
 
-- [](https://github.com/patternfly/patternfly-elements/commit/)
-- [](https://github.com/patternfly/patternfly-elements/commit/) fix: improve CLS rating in lighthouse (#1020)
+- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfelement - restore pfelement tests (#1018)
+- [fbe4423](https://github.com/patternfly/patternfly-elements/commit/fbe442396f06b0a097366512b698dc0b6d5e1f9f) fix: improve CLS rating in lighthouse (#1020)
 
 ## Prerelease 54 ( 2020-07-31 )
 

elements/pfelement/test/pfelement_cascade_attribute_test.html

@@ -11,7 +11,7 @@
     <pfe-parent test-attr="foo"></pfe-parent>
 
     <script type="module">
-      import PFElement from "../pfelement.js";
+      import PFElement from "../dist/pfelement.js";
 
       class PfeParent extends PFElement {
         static get tag() {

elements/pfelement/test/pfelement_emitEvent.html

@@ -13,7 +13,7 @@
     </pfelement>
 
     <script type="module">
-      import PFElement from "../pfelement.js";
+      import PFElement from "../dist/pfelement.js";
 
       class TestElement extends PFElement {
         static get tag() {
@@ -27,7 +27,7 @@
         }
 
         constructor() {
-          super(TestElement.tag);
+          super(TestElement);
         }
       }
 

elements/pfelement/test/pfelement_logging_test.html

@@ -11,7 +11,7 @@
     <pfe-test test-attr="1"></pfe-test>
 
     <script type="module">
-      import PFElement from "../pfelement.js";
+      import PFElement from "../dist/pfelement.js";
 
       class PfeTest extends PFElement {
         static get tag() {

elements/pfelement/test/pfelement_test.html

@@ -13,7 +13,7 @@
     </pfelement>
 
     <script type="module">
-      import PFElement from "../pfelement.js";
+      import PFElement from "../dist/pfelement.js";
 
       const colors = ["red", "yellow", "blue"];
 
@@ -29,7 +29,7 @@
         }
 
         constructor() {
-          super(TestElement.tag, { type: PFElement.PfeTypes.Content });
+          super(TestElement, { type: PFElement.PfeTypes.Content });
         }
       }
 
@@ -49,7 +49,7 @@
         }
 
         constructor() {
-          super(TestElementDelayRender.tag, { delayRender: true });
+          super(TestElementDelayRender, { delayRender: true });
         }
 
         connectedCallback() {
@@ -121,21 +121,26 @@
           });
         });
 
-        test("it should throw an error when the on attribute is manually added", done => {
+        test("it should throw an error when the on attribute is manually added", () => {
           const spy = sinon.spy(console, "warn");
 
-          const testElementEl = document.createElement("test-element");
-          testElementEl.id = "test-element";
-          testElementEl.setAttribute("on", "saturated");
-          document.body.appendChild(testElementEl);
+          // with an id
 
-          sinon.assert.calledWith(spy, `pfe-test-element[#test-element]: The "on" attribute is protected and should not be manually added to a component. The base class will manage this value for you on upgrade.`);
+          const testElementEl1 = document.createElement("test-element");
 
-          testElementEl.removeAttribute("id");
-          document.body.appendChild(testElementEl);
-          sinon.assert.calledWith(spy, `pfe-test-element: The "on" attribute is protected and should not be manually added to a component. The base class will manage this value for you on upgrade.`);
+          testElementEl1.id = "test-element";
+          testElementEl1.setAttribute("on", "saturated");
 
-          document.body.removeChild(testElementEl);
+          document.body.appendChild(testElementEl1);
+
+          sinon.assert.calledWith(spy, `test-element[#test-element]: The "on" attribute is protected and should not be manually added to a component. The base class will manage this value for you on upgrade.`);
+
+          // without an id
+
+          const testElementEl2 = document.createElement("test-element");
+          testElementEl2.setAttribute("on", "saturated");
+          document.body.appendChild(testElementEl2);
+          sinon.assert.calledWith(spy, `test-element: The "on" attribute is protected and should not be manually added to a component. The base class will manage this value for you on upgrade.`);
         });
       });
     </script>