dev-pull-request-template add testing instructions to PR template (#463)

* dev-pull-request-template  add testing instructions to PR template

* Update pull_request_template.md

removed "updated with master branch", this is enforced by github

* move PR template up to root of .github folder

* Add alert for PFE contrib list

* Add discovery template, CHANGELOG, and add those notes to the pull request template

* Update changelog with notes from release tags

* Update pull_request_template.md

Author: starryeyez024

.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

@@ -0,0 +1,49 @@
+## Title of this pull request
+
+* Link to discovery documentation (should contain all the planning and requirements for this work):
+   - See the `DISCOVERY.md` template at the root of the project
+* Link(s) to demo pages where this element can be viewed:
+
+---
+
+### What has changed and why
+Summarize files edited as part of this MR along with a brief description of what was changed/why.
+
+*
+
+### Testing instructions
+Be sure to include detailed instructions on how your update can be tested by another developer.
+
+1. 
+
+#### Browser requirements
+Your component should work in all of the following environments:
+
+- [ ] Latest 2 versions of Edge
+- [ ] Internet Explorer 11 (should be useable, not pixel perfect)
+- [ ] Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
+- [ ] Firefox 60.7.2 (or latest version for Red Hat Enterprise Linux distribution)
+- [ ] Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
+- [ ] Latest 2 versions of Safari
+- [ ] Galaxy S9 Firefox
+- [ ] iPhone X Safari
+- [ ] iPad Pro Safari
+- [ ] Pixel 3 Chrome
+
+Your repository infrastructure updates should work for at least:
+- [ ] Node v8.x
+- [ ] NPM v7.x
+
+### Ready-for-merge Checklist
+
+- [ ] Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
+- [ ] Did automated tests pass?
+- [ ] Did browser testing pass?
+- [ ] Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
+- [ ] Was this feature demo'd and the design review approved?
+- [ ] Did it get a LGTM *after the last commit*?
+- [ ] Did you update the CHANGELOG.md file with a summary of this update?
+
+
+**Be sure to share your updates with the [[email protected]](mailto:[email protected]) mailing list!**
+

.github/pull_request_template.md

@@ -0,0 +1,67 @@
+## Prerelease 18 ( TBD )
+Tag: [v1.0.0-prerelease.18](https://github.com/patternfly/patternfly-elements/releases/tag/v1.0.0-prerelease.18)
+
+- 
+
+## Prerelease 17 ( 2019-06-24 )
+Tag: [v1.0.0-prerelease.17](https://github.com/patternfly/patternfly-elements/releases/tag/v1.0.0-prerelease.17)
+
+- [1b92821d](https://github.com/patternfly/patternfly-elements/commit/1b92821de18f8c0c49a5397a8dc29b19dcbcb482) adding a check in pfe-tab-panel to see if associated tab is selected when panel is initialized ([#432](https://github.com/patternfly/patternfly-elements/pull/432))
+- [ae21a66b](https://github.com/patternfly/patternfly-elements/commit/ae21a66b090df5ac6a7f4015e0d0d6f487b00340) Update README.md ([#426](https://github.com/patternfly/patternfly-elements/pull/426))
+- [3796210b](https://github.com/patternfly/patternfly-elements/commit/3796210b038497f010356d97f92637987218ab8a) Adding 2 demo scripts to the npm package ([#430](https://github.com/patternfly/patternfly-elements/pull/430))
+
+## Prerelease 16 ( 2019-05-31 )
+Tag: [v1.0.0-prerelease.16](https://github.com/patternfly/patternfly-elements/releases/tag/v1.0.0-prerelease.16)
+
+ - [4a606dbd](https://github.com/patternfly/patternfly-elements/commit/4a606dbd4baf53478bf94780fee0dcea6624fcfc) moving this.button initialization to the constructor ([#419](https://github.com/patternfly/patternfly-elements/pull/419))
+ - [f8f9004f](https://github.com/patternfly/patternfly-elements/commit/f8f9004f81331abdccbd8f9fb76739290c0b0ef1) pfe-markdown element ([#358](https://github.com/patternfly/patternfly-elements/pull/358))
+
+## Prerelease 15 ( 2019-05-28 )
+Tag: [v1.0.0-prerelease.15](https://github.com/patternfly/patternfly-elements/releases/tag/v1.0.0-prerelease.15)
+
+- [5d6ca9e](https://github.com/patternfly/patternfly-elements/commit/5d6ca9e5441db5e5416612643122c62b2cc84d5a) add meta viewport tag to pfe-content-set demo ([#415](https://github.com/patternfly/patternfly-elements/pull/415))
+- [ee6fde4](https://github.com/patternfly/patternfly-elements/commit/ee6fde41c4859023273226439b9c045cea46418c) adding a slotchange listener and adding tests ([#407](https://github.com/patternfly/patternfly-elements/pull/407))
+- [bf8790f](https://github.com/patternfly/patternfly-elements/commit/bf8790f62722c765c20e4913def79b062ecaa3d7) Card feature updates ([#312](https://github.com/patternfly/patternfly-elements/pull/312))
+- [5d1fa72](https://github.com/patternfly/patternfly-elements/commit/5d1fa72949f0ed83bbb0752bb42ebd7637b9efb3) reset surface-border color to #d2d2d2
+- [e8260e5](https://github.com/patternfly/patternfly-elements/commit/e8260e5740275a888d142dbb001a736ae311051f) PFE-accordion border fixes
+- [84dbf03](https://github.com/patternfly/patternfly-elements/commit/84dbf031027dcca589dc6bf8176956c2b6ab305c) Pfe docs status ([#408](https://github.com/patternfly/patternfly-elements/pull/408))
+- [827aa51](https://github.com/patternfly/patternfly-elements/commit/827aa5199f2891f8b92e4765c6451a49ae853a94) Update Storybook utils to support self-closing tag ([#411](https://github.com/patternfly/patternfly-elements/pull/411))
+- [393098c](https://github.com/patternfly/patternfly-elements/commit/393098c258fb3ad8788f4e22413511b490aef93b) Rename PR template directory & file in hopes that github will use them ([#410](https://github.com/patternfly/patternfly-elements/pull/410))
+
+## Prerelease 14 ( 2019-04-30 )
+Tag: [v1.0.0-prerelease.14](https://github.com/patternfly/patternfly-elements/releases/tag/v1.0.0-prerelease.14)
+
+- Version bumps from release release/v1.0.0-prerelease.13 ([#398](https://github.com/patternfly/patternfly-elements/pull/398))
+- Adding a mutationobserver to pfe-tabs ([#402](https://github.com/patternfly/patternfly-elements/pull/402))
+- Adding a mutationobserver to pfe-accordion ([#401](https://github.com/patternfly/patternfly-elements/pull/401))
+
+## Prerelease 13 ( 2019-04-23 )
+Tag: [v1.0.0-prerelease.13](https://github.com/patternfly/patternfly-elements/releases/tag/v1.0.0-prerelease.13)
+
+- Pt 2: Storybook updates ([#277](https://github.com/patternfly/patternfly-elements/pull/277))
+- Documenting release steps ([#379](https://github.com/patternfly/patternfly-elements/pull/379))
+- Add release automation script ([#399](https://github.com/patternfly/patternfly-elements/pull/399))
+
+## Prerelease 12 ( 2019-04-22 )
+Tag: [v1.0.0-prerelease.12](https://github.com/patternfly/patternfly-elements/releases/tag/v1.0.0-prerelease.12)
+
+- On branch checkout, look for leftover elements from other branches ([#394](https://github.com/patternfly/patternfly-elements/pull/394))
+- Fix the directory of the hugo-check.sh call ([#393](https://github.com/patternfly/patternfly-elements/pull/393))
+- Add some additional information to each package file ([#382](https://github.com/patternfly/patternfly-elements/pull/382))
+
+## Prerelease 11 ( 2019-04-02 )
+Tag: [v1.0.0-prerelease.11](https://github.com/patternfly/patternfly-elements/releases/tag/v1.0.0-prerelease.11)
+
+- Removing duplicate has_slot function in PFElement ([#322](https://github.com/patternfly/patternfly-elements/pull/322))
+- Change Spandx port to auto ([#354](https://github.com/patternfly/patternfly-elements/pull/354))
+- Add autoprefixer tooling to the repo ([#334](https://github.com/patternfly/patternfly-elements/pull/334))
+
+## Prerelease 10 ( 2019-03-26 )
+Tag: [v1.0.0-prerelease.10](https://github.com/patternfly/patternfly-elements/releases/tag/v1.0.0-prerelease.10)
+
+- Update accordion styles ([#359](https://github.com/patternfly/patternfly-elements/pull/359))
+- Band layout tweaks ([#336](https://github.com/patternfly/patternfly-elements/pull/336))
+- Resolve grid gap in band layout ([#361](https://github.com/patternfly/patternfly-elements/pull/361))
+- Documentation updates ([#368](https://github.com/patternfly/patternfly-elements/pull/368))
+- Prefix pfe-avatar attributes ([#371](https://github.com/patternfly/patternfly-elements/pull/371))
+- Remove CP-theme ([#362](https://github.com/patternfly/patternfly-elements/pull/362))

CHANGELOG-prerelease.md

@@ -0,0 +1,40 @@
+# Project name
+_NOTE:_ Please convert this file to WHY.md and save it in the folder for the elements it references (i.e., `elements/pfe-cta/WHY.md`).
+
+|  |  |
+| --- | --- |
+| **Brief description of the project** |  | 
+| **Design wireframes / mock-ups** |  | 
+| **Relavant project management links** |  | 
+
+## MVP Requirements
+This project's primary goal is to...
+
+## Questions to answer
+- What **existing** components do we need to **update** to accomplish this project's main goal?
+- What **new** components do we need to accomplish this project's main goal?
+    1. Content components:
+    2. Container components:
+    3. Combo components:
+
+## Notes about styles
+* [Check w/ Design System Collaborative for Designs](https://github.com/patternfly/patternfly-unified-design-kit/projects/1)
+* [Check PF4](https://docs.google.com/spreadsheets/d/1P9iYwguDy2EnIS-Iw5ynX1Dn6FdKOR8GeZNaXGI_LNA/edit#gid=289588122)
+
+The styles for this component should...
+
+## Accessibility requirements
+As a screen-reader user, this component should...
+
+As a sighted keyboard user, this component should...
+
+## Semantics / SEO requirements
+From a semantic HTML mindset, this component should...
+
+As a search-engine, this component should...
+
+## Features to include if there is time
+If there is time, these features are nice-to-haves.
+
+## Out-of-scope // @TODO later
+These are some things we would like to add later to enhance this component.