Merge pull request #870 from patternfly/issue-869-pfe-navigation-multiple-event-listeners

fix: pfe-navigtation-item shouldn't add duplicative event listeners

Author: Djfaucette

CHANGELOG-prerelease.md

@@ -1,3 +1,7 @@
+## Prerelease 47 ( TBD )
+
+- []() fix: pfe-navigtation-item shouldn't add duplicative event listeners #870
+
 ## Prerelease 46 ( 2020-05-12 )
 
 - [27fee5f](https://github.com/patternfly/patternfly-elements/commit/27fee5f5c5eb021ac126f3767dd0299f5cda8231) fix: pfe-tabs check for tagName on addedNode mutation before continuing

elements/pfe-navigation/src/pfe-navigation-item.js

@@ -187,6 +187,8 @@ class PfeNavigationItem extends PFElement {
   constructor() {
     super(PfeNavigationItem);
 
+    this._handlersAdded = false;
+
     // States
     this.nested = false;
     this.expanded = false;
@@ -319,6 +321,10 @@ class PfeNavigationItem extends PFElement {
     this._trigger.removeEventListener("click", this._navigateToUrl);
     this._trigger.removeEventListener("keyup", this._directLinkHandler);
 
+    if (this._handlersAdded) {
+      return;
+    }
+
     // Toggle the navigation when the trigger is clicked
     this._trigger.addEventListener("click", this.toggle);
 
@@ -327,6 +333,7 @@ class PfeNavigationItem extends PFElement {
     this.addEventListener("keydown", this._keydownHandler);
 
     this._trigger.addEventListener("keyup", this._keyupHandler);
+    this._handlersAdded = true;
   }
 
   _navigateToUrl(event) {