Skip to content

Commit 6ef7f74

Browse files
authored
fix: pfe-accordion disclosure (#1003)
* fix: Disclosure hover fix * fix: Update chevron * fix: Fix sizing flicker on border when disclosure is opened/closed
1 parent d7f27c0 commit 6ef7f74

File tree

3 files changed

+15
-9
lines changed

3 files changed

+15
-9
lines changed

CHANGELOG-prerelease.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## Prerelease 54 ( TBD )
2+
3+
- []() fix: pfe-accordion border styles (#1002)
4+
15
## Prerelease 53 ( 2020-07-21 )
26

37
- [743913e](https://github.com/patternfly/patternfly-elements/commit/743913e0620ee0ca6f0cdf95cc1ed2597b5fe6e3) fix: pfe-autocomplete prevent search-event from firing twice on option select (#989)

elements/pfe-accordion/src/pfe-accordion-header.scss

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,18 +81,20 @@
8181
border-left-width: pfe-fetch(surface--border-width);
8282
}
8383

84-
&:hover {
84+
&::before {
85+
@include pfe-chevron($state: closed, $position: before, $offset: .55em);
86+
}
87+
88+
&[aria-expanded="true"]::before {
89+
transform: rotate(45deg);
90+
}
91+
92+
&[aria-expanded="true"],
93+
&:not([aria-expanded="true"]):hover {
8594
padding-left: calc(#{pfe-local(Padding, $region: base)} * 3 - #{pfe-var(surface--border-width--heavy)} + #{pfe-var(surface--border-width)});
8695
&::before {
8796
margin-left: calc((#{pfe-var(surface--border-width--heavy)} - #{pfe-var(surface--border-width)}) * -1);
8897
}
8998
}
90-
91-
&::before {
92-
@include pfe-chevron($state: open, $position: before);
93-
}
94-
&[aria-expanded="true"]::before {
95-
transform: rotate(45deg) translateY(4px);
96-
}
9799
}
98100
}

elements/pfe-sass/mixins/_components.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
@mixin pfe-accordion-props($variant: default) {
8888
margin: 0;
8989
width: pfe-local(Width, 100%);
90-
max-width: calc(100% - #{pfe-local(BorderLeftWidth)});
90+
max-width: calc(100% - #{pfe-var(surface--border-width--heavy)});
9191
height: auto;
9292
position: relative;
9393

0 commit comments

Comments
 (0)