Skip to content

Commit 7b404fe

Browse files
committed
add '.umd' and '.min' to imports of PFE interdependencies
1 parent 204bee5 commit 7b404fe

File tree

7 files changed

+386
-59
lines changed

7 files changed

+386
-59
lines changed

elements/pfe-avatar/demo/index.html

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,16 @@
1313
<script src="https://cdnjs.cloudflare.com/ajax/libs/vue/2.5.2/vue.min.js"></script>
1414

1515
<!-- uncomment the es5-adapter if you're using the umd version -->
16-
<!-- <script src="/@webcomponents/webcomponentsjs/custom-elements-es5-adapter.js"></script> -->
17-
<!-- <script src="/@webcomponents/webcomponentsjs/webcomponents-loader.js"></script> -->
18-
<!-- <script src="https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.5/require.min.js"></script> -->
19-
<!-- <script>require(['../../pfelement/pfelement.umd.js', '../pfe-avatar.umd.js'], function(PFElement) { -->
20-
<!-- PFElement.debugLog(true); -->
21-
<!-- })</script> -->
16+
<script src="/@webcomponents/webcomponentsjs/custom-elements-es5-adapter.js"></script>
17+
<script src="/@webcomponents/webcomponentsjs/webcomponents-loader.js"></script>
18+
<script src="https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.5/require.min.js"></script>
19+
<script>require(['../../pfelement/pfelement.umd.min.js', '../pfe-avatar.umd.min.js'], function(PFElement) {
20+
PFElement.debugLog(true);
21+
})</script>
2222

23-
<script type="module" src="../pfe-avatar.js"></script>
24-
<script src="../../../themes/cp-theme/cp-theme.umd.js"></script>
23+
<!-- <script type="module" src="../pfe-avatar.min.js"></script> -->
24+
<!-- <script type="module" src="../pfe-avatar.js"></script> -->
25+
<!-- <script src="../../../themes/cp-theme/cp-theme.umd.js"></script> -->
2526

2627
<style type="text/css" media="screen">
2728
/* :root {

elements/pfe-icon/gulpfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,5 @@ gulp.task("combineAndStuff", gulp.series("svgSprite", "stuffSprite"));
4747
// call the central gulp build, and pass in the custom tasks to be run pre-bundle
4848
gulpFactory({
4949
...pfelementPackage.pfelement,
50-
precompile: ["combineAndStuff"]
50+
prebundle: ["combineAndStuff"]
5151
});

elements/pfelement/src/pfelement.js

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)