fix(select): restore and fix chevron

Closes #1801

Author: bennypowers

.changeset/empty-cougars-remain.md

@@ -0,0 +1,5 @@
+---
+"@patternfly/pfe-select": patch
+---
+
+Restores chevrom in pfe-select, and passes click events on it to the select menu.

.changeset/soft-radios-hear.md

@@ -0,0 +1,6 @@
+---
+"@patternfly/pfe-sass": major
+---
+
+Removes `pfe-arrow` SASS mixin. This mixin was only used in one place,
+pfe-select, so it's contents were transfered to that file.

core/pfe-sass/mixins/_mixins.scss

@@ -1,3 +1,5 @@
+@use 'sass:map';
+
 @mixin browser-query($browser-list) {
   @each $browser in $browser-list {
     @if $browser == edge12 {
@@ -31,26 +33,6 @@
   transition: $return;
 }
 
-// Make a CSS arrow
-@mixin pfe-arrow($type, $color, $width: 8px, $height: 5px, $pseudo: false) {
-  $direction: (
-    up: 180deg,
-    down: 0deg,
-    right: -90deg,
-    left: 90deg,
-  );
-  border-style: pfe-var(surface--border-style);
-  border-width: $width $height 0;
-  border-color: transparent;
-  border-top-color: $color;
-  transform: rotate(map-get($direction, $type));
-  @if $pseudo {
-    display: inline-block;
-    content: "";
-    @content;
-  }
-}
-
 @mixin pfe-arrow-color($color) {
   border-top-color: $color;
 }

elements/pfe-select/pfe-select.scss

@@ -45,16 +45,16 @@
   color:            pfe-local(Color);
 
   &::after {
-    @include pfe-arrow(
-      $type: down,
-      $color: $pf-color-black-800,
-      $width: 6px,
-      $height: 6px,
-      $pseudo: true) {
-        position: absolute;
-        top: calc(#{pfe-var(container-padding)} * 0.875);
-        right: calc(#{pfe-var(container-padding)} * 0.75);
-    }
+    border-style: pfe-var(surface--border-style);
+    border-width: 6px 6px 0;
+    border-color: transparent;
+    border-top-color: $pf-color-black-800;
+    display: inline-block;
+    content: "";
+    position: absolute;
+    pointer-events: none;
+    top: calc(#{pfe-var(container-padding)} * 0.875);
+    right: calc(#{pfe-var(container-padding)} * 0.75);
   }
 
   @at-root #{&}([hidden]) {