Skip to content

Commit 907d8f8

Browse files
authored
docs: v3 in dropdown (#2704)
* docs: v3 in dropdown * docs: adjust dropdown dom see #2703
1 parent d65a860 commit 907d8f8

File tree

3 files changed

+32
-41
lines changed

3 files changed

+32
-41
lines changed

docs/_data/versions.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,15 @@
11
[
2+
{
3+
"version": "v3.0.0",
4+
"slug": "v3",
5+
"label": "v3",
6+
"current": true
7+
},
28
{
39
"version": "v2.0.0",
410
"slug": "v2",
511
"label": "v2",
6-
"current": true
12+
"current": false
713
},
814
{
915
"version": "v1.12.3",

docs/_includes/_nav.njk

Lines changed: 19 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -12,48 +12,27 @@
1212
<img alt="PatternFly Elements"
1313
src="{{ '/images/pfe-logo-icon-white.svg' | url }}"
1414
width="57.5" height="57.5">
15-
</picture>
15+
</picture>
1616
</a>
1717
</div>
18-
{# TODO: implement pf-dropdown
19-
<pf-dropdown id="docs-versions-dropdown" aria-label="Docs Versions" label="Docs Versions">
20-
{% for version in versions %}
21-
{%- if version.current -%}
22-
{%- set prefix = '' -%}
23-
{%- else -%}
24-
{%- set prefix = '/' + version.slug -%}
25-
{%- endif %}
26-
<pf-dropdown-item
27-
item-type="link"
28-
data-version="{{ version.slug }}"
29-
data-label="{{ version.label }}">
30-
<a href="{{ prefix }}{{ page.url }}">{{ version.label }}</a>
31-
</pf-dropdown-item>
32-
{% endfor %}
18+
<pf-dropdown id="docs-versions-dropdown">
19+
<pf-button slot="trigger"
20+
variant="control"
21+
icon="caret-down"
22+
icon-set="fas">Versions</pf-button>
23+
<pf-dropdown-menu slot="menu">
24+
{% for version in versions %}
25+
{%- if version.current -%}
26+
{%- set prefix = '' -%}
27+
{%- else -%}
28+
{%- set prefix = '/' + version.slug -%}
29+
{%- endif %}
30+
<pf-dropdown-item href="{{ prefix }}{{ page.url }}" {{ 'disabled' if version.current }}>
31+
{{ version.label }}
32+
</pf-dropdown-item>
33+
{% endfor %}
34+
</pf-dropdown-menu>
3335
</pf-dropdown>
34-
#}
35-
<select id="docs-versions-dropdown" aria-label="Docs Versions" oninput="location.href=this.options[this.selectedIndex].value">
36-
{% for version in versions %}
37-
{%- if version.current -%}
38-
{%- set prefix = '' -%}
39-
{%- else -%}
40-
{%- set prefix = '/' + version.slug -%}
41-
{%- endif %}
42-
<option
43-
value="{{ prefix }}{{ page.url }}"
44-
data-version="{{ version.slug }}"
45-
data-label="{{ version.label }}">{{ version.label }}</option>
46-
{% endfor %}
47-
</select>
48-
<script type="module">
49-
const dropdown = document.getElementById('docs-versions-dropdown');
50-
const items = dropdown.querySelectorAll('[data-version]');
51-
const versions = Object.fromEntries(Array.from(items, x => [x.dataset.version, x]));
52-
const [fst] = new URL(location.href).pathname.split('/').filter(Boolean);
53-
let [highest] = Object.keys(versions).sort().reverse();
54-
const selected = fst in versions ? versions[fst] : versions[highest];
55-
dropdown.setAttribute('label', selected.dataset.label);
56-
</script>
5736
</div>
5837
</div>
5938

@@ -62,7 +41,7 @@
6241
data-controls="mobile-menu-menu-container">
6342
<span class="l-header__burger-icon"></span>
6443
<span class="menu-toggle-assistive-text element-invisible">Toggle menu visibility</span>
65-
</label>
44+
</label>
6645
<div class="menu-toggle__toggleable site-navigation__outer-wrapper">
6746
<nav class="l-header__site-navigation site-navigation menu-toggle__toggleable-content-wrapper">
6847
<ul class="site-navigation__wrapper">

netlify.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,9 @@
66
to = 'https://release-v1--patternfly-elements.netlify.app/:splat'
77
status = 200
88
force = true
9+
10+
[[redirects]]
11+
from = '/v2/*'
12+
to = 'https://release-v2--patternfly-elements.netlify.app/:splat'
13+
status = 200
14+
force = true

0 commit comments

Comments
 (0)