fix(accordion): fixed issue where accordion set active roving tabindex item incorrectly

Nikki Massaro Kauffman · Nikki Massaro Kauffman · commit 9fd36aae0f4b · 2023-07-13T12:06:26.000-04:00
diff --git a/elements/pf-accordion/BaseAccordion.ts b/elements/pf-accordion/BaseAccordion.ts
@@ -97,7 +97,7 @@ export abstract class BaseAccordion extends LitElement {
   get #activeHeader() {
     const { headers } = this;
     const index = headers.findIndex(header => header.matches(':focus,:focus-within'));
-    return headers.at(index);
+    return index > -1 ? headers.at(index) : undefined;
   }
 
   protected expandedSets = new Set<number>();
@@ -162,7 +162,7 @@ export abstract class BaseAccordion extends LitElement {
     this.updateAccessibility();
   }
 
-  #updateActiveHeader() {
+  #updateActiveHeader(event: FocusEvent) {
     if (this.#activeHeader) {
       this.#headerIndex.updateActiveItem(this.#activeHeader);
     }

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ export abstract class BaseAccordion extends LitElement {`
`97`	`97`	`get #activeHeader() {`
`98`	`98`	`const { headers } = this;`
`99`	`99`	`const index = headers.findIndex(header => header.matches(':focus,:focus-within'));`
`100`		`- return headers.at(index);`
	`100`	`+ return index > -1 ? headers.at(index) : undefined;`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`protected expandedSets = new Set<number>();`
`@@ -162,7 +162,7 @@ export abstract class BaseAccordion extends LitElement {`
`162`	`162`	`this.updateAccessibility();`
`163`	`163`	`}`
`164`	`164`
`165`		`- #updateActiveHeader() {`
	`165`	`+ #updateActiveHeader(event: FocusEvent) {`
`166`	`166`	`if (this.#activeHeader) {`
`167`	`167`	`this.#headerIndex.updateActiveItem(this.#activeHeader);`
`168`	`168`	`}`