Merge branch 'main' into docs/remove-skip-link-animation

Author: zeroedin

.changeset/late-actors-give.md

@@ -0,0 +1,5 @@
+---
+"@patternfly/elements": patch
+---
+
+`pf-accordion`: fixed issue with focus event triggering incorrect tabindex

elements/pf-accordion/BaseAccordion.ts

@@ -97,7 +97,7 @@ export abstract class BaseAccordion extends LitElement {
   get #activeHeader() {
     const { headers } = this;
     const index = headers.findIndex(header => header.matches(':focus,:focus-within'));
-    return headers.at(index);
+    return index > -1 ? headers.at(index) : undefined;
   }
 
   protected expandedSets = new Set<number>();
@@ -162,7 +162,7 @@ export abstract class BaseAccordion extends LitElement {
     this.updateAccessibility();
   }
 
-  #updateActiveHeader() {
+  #updateActiveHeader(event: FocusEvent) {
     if (this.#activeHeader) {
       this.#headerIndex.updateActiveItem(this.#activeHeader);
     }

elements/pf-accordion/test/pf-accordion.spec.ts

@@ -386,7 +386,6 @@ describe('<pf-accordion>', function() {
           });
         });
 
-
         describe('Shift+Tab', function() {
           beforeEach(press('Shift+Tab'));
           it('moves focus to the body', function() {
@@ -614,7 +613,7 @@ describe('<pf-accordion>', function() {
             describe('Tab', function() {
               beforeEach(press('Tab'));
               it('moves focus to the body', function() {
-                expect(document.activeElement).to.equal(header3);
+                expect(document.activeElement).to.equal(document.body);
               });
               describe('Shift+Tab', function() {
                 beforeEach(press('Shift+Tab'));
@@ -1189,7 +1188,7 @@ describe('<pf-accordion>', function() {
 
         describe('Navigating from parent to child accordion', function() {
           describe('Opening the panel containing the nested accordion and pressing TAB', function() {
-            beforeEach(press(' '));
+            beforeEach(press('Space'));
             beforeEach(press('Tab'));
             it('moves focus to the nested accordion header', function() {
               expect(document.activeElement).to.equal(nestedHeaderOne);
@@ -1225,8 +1224,8 @@ describe('<pf-accordion>', function() {
 
             describe('Tab', function() {
               beforeEach(press('Tab'));
-              it('should move focus back to the parent accordion', function() {
-                expect(document.activeElement).to.equal(topLevelHeaderThree);
+              it('should move focus back to the body', function() {
+                expect(document.activeElement).to.equal(document.body);
               });
             });
           });