Merge pull request #1766 from patternfly/pfe-tabs-null-fix

Djfaucette · web-flow · commit b18dd64da950 · 2021-09-02T10:51:06.000-04:00
fix: fix for re-renders when there is no selectedindex
diff --git a/elements/pfe-tabs/src/pfe-tabs.js b/elements/pfe-tabs/src/pfe-tabs.js
@@ -270,7 +270,7 @@ class PfeTabs extends PFElement {
       this.selectedIndex = tabIndexFromURL;
     }
 
-    if (!this.selectedIndex) this.selectedIndex = 0;
+    if (this.selectedIndex === null) this.selectedIndex = 0;
 
     if (window.ShadyCSS) this._observer.observe(this, TABS_MUTATION_CONFIG);
   }

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ class PfeTabs extends PFElement {`
`270`	`270`	`this.selectedIndex = tabIndexFromURL;`
`271`	`271`	`}`
`272`	`272`
`273`		`- if (!this.selectedIndex) this.selectedIndex = 0;`
	`273`	`+ if (this.selectedIndex === null) this.selectedIndex = 0;`
`274`	`274`
`275`	`275`	`if (window.ShadyCSS) this._observer.observe(this, TABS_MUTATION_CONFIG);`
`276`	`276`	`}`