Skip to content

Commit b2384c2

Browse files
committed
PFE Content set code revisions
* removed old instructional text from content-set readme file * added broken content set example * uncommented onclick js event for tabs
1 parent 6141910 commit b2384c2

File tree

4 files changed

+12
-3
lines changed

4 files changed

+12
-3
lines changed

elements/pfe-content-set/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ Requires both the `pfe-accordion` and `pfe-tabs` components, as well as the base
1313

1414
## Usage
1515

16-
<!-- You must wrap each chunk of information (heading + content) in a `<pfe-content-set-group>` tag. -->
1716
Each header must have an attribute of `pfe-content-set--header` and each panel must have an attribute of `pfe-content-set--panel`. Each header must be immediately followed by a panel.
1817

1918
```html

elements/pfe-content-set/demo/index.html

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,14 @@ <h2 pfe-content-set--header>Heading 2</h2>
246246
<div pfe-content-set--panel>Content for heading 2.</div>
247247
</pfe-content-set>
248248

249-
249+
<h2>This content set's markup is incorrect.</h2>
250+
<pfe-content-set>
251+
<h2>Heading 1</h2>
252+
<div>
253+
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean eu leo quam. Pellentesque ornare sem lacinia quam venenatis vestibulum. Cras justo odio, dapibus ac facilisis in, egestas eget quam.</p>
254+
</div>
255+
<h2>Heading 2</h2>
256+
<div>Nullam quis risus eget urna mollis ornare vel eu leo. Maecenas sed diam eget risus varius blandit sit amet non magna. Cras justo odio, dapibus ac facilisis in, egestas eget quam.</div>
257+
</pfe-content-set>
250258
</body>
251259
</html>

elements/pfe-tabs/src/pfe-tabs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ class PfeTabs extends PFElement {
153153
super.connectedCallback();
154154

155155
this.addEventListener("keydown", this._onKeyDown);
156-
// this.addEventListener("click", this._onClick);
156+
this.addEventListener("click", this._onClick);
157157

158158
if (!this.hasAttribute("role")) {
159159
this.setAttribute("role", "tablist");

examples/index.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ <h1>Demos</h1>
2222
<li><a href="../elements/pfe-icon/demo">pfe-icon</a></li>
2323
<li><a href="../elements/pfe-icon-panel/demo">pfe-icon-panel</a></li>
2424
<li><a href="../elements/pfe-layouts/demo">pfe-layouts</a></li>
25+
<li><a href="../elements/pfe-link-list/demo">pfe-link-list</a></li>
26+
<li><a href="../elements/pfe-navigation/demo">pfe-navigation</a></li>
2527
<li><a href="../elements/pfe-number/demo">pfe-number</a></li>
2628
<li><a href="../elements/pfe-tabs/demo">pfe-tabs</a></li>
2729
</ul>

0 commit comments

Comments
 (0)