Skip to content

Commit b342693

Browse files
fix: move max-width: 100px from menu triggers to icon triggers (#849)
* US246496 removed max-width: 100px from triggers * Code revision, added changelog Co-authored-by: [ Cassondra ] <[email protected]>
1 parent 6eed4c3 commit b342693

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

CHANGELOG-prerelease.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
- [2c950b0](https://github.com/patternfly/patternfly-elements/commit/2c950b08f7638787df50aa5ee6738f1205ea3a9d) fix: Add clearfix within tab and accordion panels
55
- [96f0a1b](https://github.com/patternfly/patternfly-elements/commit/96f0a1bdf9c758650e02b20a63ee3fb2fcf11bc9) feat: Add border to the card component
66
- [f392a0f](https://github.com/patternfly/patternfly-elements/commit/f392a0f0eeac3b0379794eff4a1b2946e10e883a) fix: Generator needs to convert slot-name to camelCase in js file if dash exists
7-
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: adjust arrow spacing & alignment on pfe-cta
8-
7+
- [6eed4c3](https://github.com/patternfly/patternfly-elements/commit/6eed4c3dae562e20c12879b2790cb68031e8975e) fix: adjust arrow spacing & alignment on pfe-cta
8+
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: Move max-width:100px to icon triggers
99

1010
## Prerelese 45 ( 2020-04-27 )
1111

elements/pfe-navigation/src/_shared-assets.scss

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,18 +64,11 @@ $variables: (
6464
margin: 0 !important;
6565
max-width: 100%; // added
6666
text-align: center;
67-
// max-width: #{pfe-local($cssvar: MaxWidth, $region: trigger, $fallback: 100%)};
6867

6968
@media screen and (min-width: pfe-breakpoint(xs) ) {
70-
// --pfe-navigation__trigger--MaxWidth: 100%; // added
7169
max-width: 100%;
7270
}
73-
@media screen and (min-width: pfe-breakpoint(sm-desktop, $map: false) ) {
74-
// --pfe-navigation__trigger--MaxWidth: 100px; // added
75-
max-width: 100px;
76-
}
7771
@media screen and (min-width: pfe-breakpoint(xl) ) {
78-
// --pfe-navigation__trigger--MaxWidth: 190px; // added
7972
max-width: 190px;
8073
}
8174
}

elements/pfe-navigation/src/pfe-navigation-item.scss

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -262,14 +262,11 @@ $variables: map-merge($variables, $nav-item-variables);
262262
}
263263

264264
// Typography styles need specificity over bootstrap
265-
266265
::slotted([slot="trigger"]) {
267266
@extend %trigger;
268-
}
269-
270-
:host([pfe-icon]) {
271-
::slotted([slot="trigger"]) {
267+
:host([pfe-icon]) & {
272268
margin: 0.25em 0 0 0 !important;
269+
max-width: 100px;
273270
}
274271
}
275272

0 commit comments

Comments
 (0)