fix: pfelement - only resetContext on a nested child element during contextUpdate if resetContext is available on the child element (#1704)

* fix: wait for nested children to upgrade before calling resetContext on them

Fixes #1703

* adding changelog update

* removing isUpgraded property since its not used

* the promise in contextUpdate for nested elements is no longer needed

* updating changelog for pfelement fix

* increasing diff ratio just a hair for pfe-dropdown

Author: kylebuch8

CHANGELOG-1.x.md

@@ -1,9 +1,11 @@
 # 1.10.1 (2021)
 
+- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfelement - only resetContext on a nested child element during contextUpdate if resetContext is available on the child
 - [fdc60ab](https://github.com/patternfly/patternfly-elements/commit/) fix: pfe-tabs issue with active border color on horizontal/wind (#1585)
 
 # 1.10.0 (2021-07-08)
 
+- [c9c3b56](https://github.com/patternfly/patternfly-elements/commit/c9c3b5654ac05875eabfce0727c54af183e4ac09) chore: Minor testing updates
 - [af4bc70](https://github.com/patternfly/patternfly-elements/commit/af4bc7063b995c316320f6df706b744133f1753d) feat: Jump links navigation rework to support panel customizations and elements in separate DOMs; horizontal designs aligned to kit
 
 

elements/pfe-dropdown/test/pfe-dropdown_e2e.js

@@ -24,6 +24,6 @@ describe(element, () => {
   });
 
   it("should compare to the baseline", () => {
-    expect(browser.checkFullPageScreen(element)).toBeLessThan(1.45);
+    expect(browser.checkFullPageScreen(element)).toBeLessThan(1.52);
   });
 });

elements/pfelement/src/pfelement.js

@@ -328,11 +328,12 @@ class PFElement extends HTMLElement {
 
     // Loop over the nested elements and reset their context
     nestedEls.map((child) => {
-      this.log(`Update context of ${child.tagName.toLowerCase()}`);
-      Promise.all([customElements.whenDefined(child.tagName.toLowerCase())]).then(() => {
+      if (child.resetContext) {
+        this.log(`Update context of ${child.tagName.toLowerCase()}`);  
+        
         // Ask the component to recheck it's context in case it changed
         child.resetContext(this.on);
-      });
+      }
     });
   }
 

elements/pfelement/test/pfelement_test.html

@@ -180,6 +180,19 @@
         // Class-thrown error
         assert.throws(() => PFElement.error("Hey!"), "Hey!");
       });
+
+      test("it should have a pfelement attribute after the component has been initialized", done => {
+        const testElement = document.createElement("pfe-test-element");
+        assert.isFalse(testElement.hasAttribute("pfelement"));
+
+        document.body.appendChild(testElement);
+
+        flush(() => {
+          assert.isTrue(testElement.hasAttribute("pfelement"));
+          document.body.removeChild(testElement);
+          done();
+        });
+      });
     });
   </script>