Skip to content

Commit c57c5dd

Browse files
authored
fix(tools): redirect dev server for lightdom css (#2749)
1 parent 759f5e6 commit c57c5dd

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

.changeset/odd-months-flow.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
"@patternfly/pfe-tools": patch
3+
---
4+
Dev Server: redirect demo links to css lightdom subresources

tools/pfe-tools/dev-server/plugins/pfe-dev-server.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,8 @@ function getRouter(options: PfeDevServerInternalConfig) {
103103
})
104104

105105
// Redirect `components/jazz-hands/*-lightdom.css` to `elements/pf-jazz-hands/*-lightdom.css`
106-
.get(`/${componentSubpath}/:element/:fileName-lightdom.css`, async (ctx, next) => {
106+
// NOTE: don't put subresources in /demo called `*-lightdom.css` , or this will break
107+
.get(`/${componentSubpath}/:element/(demo/)?:fileName-lightdom.css`, async (ctx, next) => {
107108
const { element, fileName } = ctx.params;
108109
if (!element.startsWith(tagPrefix)) {
109110
const prefixedElement = deslugify(element);
@@ -118,7 +119,11 @@ function getRouter(options: PfeDevServerInternalConfig) {
118119
const { element, splat, fileName, ext } = ctx.params;
119120
const prefixedElement = deslugify(element);
120121
if (!element.includes(tagPrefix)) {
121-
ctx.redirect(`/${elementsDir}/${prefixedElement}/demo/${splat}/${fileName}.${ext}`);
122+
if (splat) {
123+
ctx.redirect(`/${elementsDir}/${prefixedElement}/demo/${splat}/${fileName}.${ext}`);
124+
} else {
125+
ctx.redirect(`/${elementsDir}/${prefixedElement}/demo/${fileName}.${ext}`);
126+
}
122127
} else {
123128
return next();
124129
}

0 commit comments

Comments
 (0)