fix(select): variant attr, tests (#2677)

* fix(select): variant attr, tests

* fix(select): add accessibleToggleLabel

* fix(select): make accessibleToggleLabel not default to ''

* fix(select): badges and typeahead

* fix(core): add willChange to toggleController

* docs(select): update typehead demos with variant attr

* docs(select): remove extra multi attr

* docs(select): correct checkbox demo to use variant attr

* fix(select): update badge on keyboard select

* docs(select): remove duplicative demo, rename chip to checkbox hide badge

* fix(select):  rename selectedList

consider removing this

* test(select): more keyboard tests

* fix(select): factor out always-expanded and selectedList

* fix(select): create toggleController

* test(select): tiny refactor

* fix(select): option value defaults to textContent

like HTMLOptionElement.value

* fix(select): remove match-anywhere and case-sensitive, add customFilter

* test(select): add cases

* perf(core): prevent memory leak in listboxcontroller

* fix(select): tabbing out of listbox

* fix(select): rename attr

* docs(select): custom filter demo

* fix(select): non-chrome toggle

* fix(select): toggle focus listbox

* docs(select): update some demos

* docs(select): more docs

* feat(select): label attr for option group

* fix(core): workaround for delegatesFocus cross-browser issue

* docs(select): custom filtering example

* fix(select): remove create option feature, implement FACE

pfv5 removes the complicated logic for creating options, making it a "pattern" instead. We opt not to implement that feature here

* style: small refactors

* refactor(select)!: remove typeahead and rename listbox controller

* fix(select): tests green

* docs(select): align with pf v4 docs

* fix(select): change hide-badge to checkbox-selection-badge-hidden

* fix: tabs controller internal apis

a later pr will fix this for real

* fix(chip): hide empty group

* fix(select): change default-text to placeholder

and make it an attr/slot pair

* test(select): update test cases

The changes to placeholder behaviour in 563fa52 required updating test cases,
since now the placeholder is treated for all intents and purposes as a
disabled option

---------

Co-authored-by: Steven Spriggs <[email protected]>

Author: bennypowers

core/pfe-core/controllers/internals-controller.ts

@@ -69,8 +69,9 @@ export class InternalsController implements ReactiveController, ARIAMixin {
     // using a public static constructor method is much easier to manage,
     // due to the quirks of our typescript config
     const instance: InternalsController =
-      InternalsController.instances.get(host) ?? new InternalsController(host, options);
-    instance.initializeAriaMixinPropertyValues(options);
+      InternalsController.instances.get(host) ??
+      new InternalsController(host, options);
+    instance.initializeOptions(options);
     constructingAllowed = false;
     return instance;
   }
@@ -175,7 +176,7 @@ export class InternalsController implements ReactiveController, ARIAMixin {
       throw new Error('InternalsController must be instantiated with an HTMLElement or a `getHTMLElement` function');
     }
     this.attach();
-    this.initializeAriaMixinPropertyValues(options);
+    this.initializeOptions(options);
     InternalsController.instances.set(host, this);
     this.#polyfillDisabledPseudo();
   }
@@ -210,8 +211,11 @@ export class InternalsController implements ReactiveController, ARIAMixin {
     return this.internals;
   }
 
-  private initializeAriaMixinPropertyValues(options?: Partial<ARIAMixin>) {
-    for (const [key, val] of Object.entries(options ?? {})) {
+  private initializeOptions(options?: Partial<ARIAMixin>) {
+    this.options ??= options ?? {};
+    const { getHTMLElement, ...aria } = this.options;
+    this.options.getHTMLElement ??= getHTMLElement;
+    for (const [key, val] of Object.entries(aria)) {
       if (isARIAMixinProp(key)) {
         this[key] = val;
       }