Commit daf5ca0
pfe-cta bug fixes + open brand styles (#353)
* CTA bug fixes; variable adjustments, remove !importants
* Working on tests for pfe-cta
* Pull out hide-show component
* Update the tests
* US212681 added focus state mixin; updated padding
* US212681 reset CTA primary and secondary padding
* PFE-CTA bug: switched ui-accent color variable.
* Update color variable
* US212681 pfe-cta focus styles
* US212681 removed iconfont from cta, applied logic to display arrow svg for default CTAs
* US212681 fixed on dark variants for default, primary and secondary
* US212681 fixed primary cta bg hover color, commented out alt styles
* US212681 set complement and base styles to map to alt variants
* US212681 reverted color var changes
* US212681 fixed secondary focus state, fixed default focus and hover states
* US212681 refactored color vars for pfe-ctas.
* US212681 added alt versions for primary and secondary
* US212681 removed on=dark from demo; provided broadcast var overrides
* US212681 shifted bg color styles to the host, applied focus-within and hover styles to the host.
* US212681 override broadcast variables for secondary cta hover states.
* US212681 removed non-default focus outline, applied all padding to slotted a.
* US212681 moved before pseudo element to the slotted a on focus-within
* US212681 overrode broadcast color var for secondary links when hover is on host and focus is on a.
* Playing with how styles are applied
* US212681 fixed focus state styles.
* US212681 fixed default hover issue: color--hover to slotted(a) on host hover.
* US212681 added important flag to hover color custom property
* US212681 applied broadcast overrides to fix hover bug
* US212681 added the !important flag on link hover, fixed secondary "active" color states.
* US212681 set outline on focus states to none !important.
* pfe-cta-broadcast-updates
- remove function in pfe-band.js and pfe-card.js that adds on=dark to CTAs
- set broadcast interruption once in the middle of the CTA color vars map, only to be overridden by color attributes
* pfe-cta-broadcast-updates
- adjust arrow placement so its inline, and so that it doesnt move things around it on hover
* fix layouts
* - remove updateContext functions from band & card
- set theme-complement as blue inside of pfe-cta in the demo file
- more demo file tweaks
- remove color="alt" , we are just using color=complement
* pfe-cta-broadcast-updates Add docs about broadcasted vars
* pfe-cta-broadcast-updates tidy comments
* US212681 simplified alt ctas
* pfe-cta-broadcast-updates Tidy demo file, update complement hover fallback color to match link blue
* pfe-cta-broadcast-updates fix closing paren
* remove fallback-only function (unused)
* pfe-cta-broadcast-updates - update font family, fix secondary focus color, add primary lightest
* US212681 revert alt changes
* Update package-lock
* Add a focus event and blur event to attach the class to the element
* Hardening the approach to attaching the focus state class
* updated README documentation
* US212681 fix cta test to match warning.
* pfe-cta-bug-fixes remove "base" from storybook demos
* Add polyfill for the includes statement
* Add schema to JS
* fixing the connectedCallback so it only runs this._init if there are children
* removing the .includes polyfill
We need to work on removing the polyfills from our code and start relying them on a more global level.
* changing the link property to a cta property
For some reason the link property is no longer available. However, using the cta property seems to fix the test.
* making the supported tags a bit more readable in the code
* Add comments and wrap event listeners in element checks
* Remove duplciate event listener attachment
* Move the event attachment to the init
* Remove this._slot check; no necessito
* Add back the attributeChangedCallback
* pfe-cta-bug-fixes add support for fallback and legacy styles
* pfe-cta-bug-fixes remove spaces, cleanup debug code
* pfe-cta-bug-fixes remove unnecessary interpolation syntax, spacing cleanup, and use color function instead of fallback,
* pfe-cta-bug-fixes Add support for link in the light dom for edge & ie11, add back interpolation syntax, add IE11 overrides for card & band
* pfe-cta-bug-fixes update attributes to have pfe- prefix
* update schema with correct values; update transition property so it only applies to padding, update docs, remove lerna version upgrade
* Sass cleanup: group hover & focus styles since those colors appear together on the page. Adjusted slotted states + host states
* spacing cleanup
* ie11 hacks
* remove card/band stuff
* reset band demo
* Update docs
* revert dependeny update
* updated package-lock
* Fix JS reference to pfe-priority (fixes arrow showing up on buttons); switch from using surface colors to ui-colors - this solves our color issue without needing updates to our theme.
* Remove deprecated on="dark"
* Pull back unnecessary pfe-band.html updates; clean up readme reference
* Fix typo in card padding variable name
* Tidy up storybook
* Resolve typos in pfe-cta--lightdom stylesheet
* Comment out unused code from the test file
* US212681 set pfe-color attributes to match their theme variable names.
* US212681 set secondary color styles to map to ui-complement.
* US212681 set secondary hover to surface--lighter
* US212681 added secondary pfe-color=lightest variant
* US212681 applied pale gray bg to all bg focus states for secondary
* US212681 adjusted focus background for alt secondary ctas
* pfe-cta-bug-fixes revert package-lock.json
* US212681 removed nav and link-list from examples index file
* US212678 added base option to pfe-color in storybook.
* US212681 added pfe-color="base" cta styles to at a glance.
* pfe-cta-bug-fixes revert changes to pfe-cta.js export1 parent efd115b commit daf5ca0
File tree
20 files changed
+8522
-7180
lines changed- elements
- pfe-band/src
- pfe-card
- demo
- src
- pfe-cta
- demo
- src
- test
- pfe-sass
- functions
- variables
- pfelement
20 files changed
+8522
-7180
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
| 146 | + | |
150 | 147 | | |
151 | 148 | | |
152 | 149 | | |
| |||
169 | 166 | | |
170 | 167 | | |
171 | 168 | | |
172 | | - | |
173 | | - | |
| 169 | + | |
174 | 170 | | |
175 | 171 | | |
176 | 172 | | |
| |||
179 | 175 | | |
180 | 176 | | |
181 | 177 | | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
| 178 | + | |
196 | 179 | | |
197 | 180 | | |
198 | 181 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
| |||
78 | 77 | | |
79 | 78 | | |
80 | 79 | | |
81 | | - | |
| 80 | + | |
82 | 81 | | |
83 | 82 | | |
84 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | 130 | | |
135 | 131 | | |
136 | 132 | | |
| |||
159 | 155 | | |
160 | 156 | | |
161 | 157 | | |
162 | | - | |
163 | | - | |
| 158 | + | |
164 | 159 | | |
165 | 160 | | |
166 | 161 | | |
| |||
169 | 164 | | |
170 | 165 | | |
171 | 166 | | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | 167 | | |
189 | 168 | | |
190 | 169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
18 | 26 | | |
19 | 27 | | |
20 | 28 | | |
| |||
25 | 33 | | |
26 | 34 | | |
27 | 35 | | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
45 | 63 | | |
46 | 64 | | |
47 | 65 | | |
| |||
50 | 68 | | |
51 | 69 | | |
52 | 70 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
57 | 74 | | |
58 | 75 | | |
59 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
0 commit comments