fix: loosen nodejs version restrictions for users and developers (#1748)

mwcz · github-actions[bot] · heyMP · web-flow · commit e698e9a11a8c · 2021-09-14T09:49:37.000-04:00
* release in test mode

* update lock

* build: set supported build envs to 12-16

* suggest nvm in readme, set engines to node 10+

* support node 12+ for root devtools, all versions for components

* reactivate accidentally commented release script lines

* remove node 16 from test suite and supported build engines

* add avn/nvm suggestion to README

Co-authored-by: Michael Potter &lt;mgp140@gmail.com&gt;

Co-authored-by: github-actions[bot] &lt;41898282+github-actions[bot]@users.noreply.github.com&gt;
Co-authored-by: Michael Potter &lt;mgp140@gmail.com&gt;
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -48,7 +48,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: ['12.x']
+        node: ['12.x', '14.x']
     if: |
       (
         github.event_name == 'pull_request' &&
diff --git a/README.md b/README.md
@@ -26,6 +26,9 @@ npm run dev -- --storybook --docs # This will build and spin up a local server w
 ```
 
 ### Additional dependencies
+
+#### Hub
+
 If you will be doing any release work, it is recommended that you install Hub.
 
 To install on a MacOS: `brew install hub`.
@@ -35,6 +38,10 @@ For other systems, please see documentation:
 
 _Note: You will need to use [Node](https://nodejs.org/en/) v12 or higher._
 
+#### nvm
+
+Building PatternFly Elements requires specific versions of Node.js.  To automate usage of the correct version, it is recommended that contributors install [nvm](https://github.com/nvm-sh/nvm#readme) as well an automatic version switcher like [avn](https://github.com/wbyoung/avn) or [shell-specific nvm integration](https://github.com/nvm-sh/nvm#deeper-shell-integration).  With those installed, your terminal will automatically switch to the correct Node.js version when you `cd` into the PatternFly Elements repository.
+
 ## Command Line Helper Scripts
 Many commands have an optional argument of space-separated component name(s), if left off it will assume it should run on all components. These should run from the project root.
 
diff --git a/elements/pfe-accordion/package.json b/elements/pfe-accordion/package.json
@@ -24,9 +24,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-accordion"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-autocomplete/package.json b/elements/pfe-autocomplete/package.json
@@ -16,9 +16,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-autocomplete"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-avatar/package.json b/elements/pfe-avatar/package.json
@@ -16,9 +16,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-avatar"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-badge/package.json b/elements/pfe-badge/package.json
@@ -16,9 +16,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-badge"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-band/package.json b/elements/pfe-band/package.json
@@ -21,9 +21,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-band"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-button/package.json b/elements/pfe-button/package.json
@@ -22,9 +22,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-button"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-card/package.json b/elements/pfe-card/package.json
@@ -19,9 +19,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-card"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-clipboard/package.json b/elements/pfe-clipboard/package.json
@@ -22,9 +22,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-clipboard"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-content-set/package.json b/elements/pfe-content-set/package.json
@@ -16,9 +16,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-content-set"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-cta/package.json b/elements/pfe-cta/package.json
@@ -20,9 +20,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-cta"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-datetime/package.json b/elements/pfe-datetime/package.json
@@ -15,9 +15,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-datetime"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-dropdown/package.json b/elements/pfe-dropdown/package.json
@@ -16,9 +16,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-dropdown"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-health-index/package.json b/elements/pfe-health-index/package.json
@@ -19,9 +19,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-health-index"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-icon-panel/package.json b/elements/pfe-icon-panel/package.json
@@ -19,9 +19,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-icon-panel"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-icon/package.json b/elements/pfe-icon/package.json
@@ -19,9 +19,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-icon"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-jump-links/package.json b/elements/pfe-jump-links/package.json
@@ -22,9 +22,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-jump-links"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-markdown/package.json b/elements/pfe-markdown/package.json
@@ -12,9 +12,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-markdown"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-modal/package.json b/elements/pfe-modal/package.json
@@ -19,9 +19,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-modal"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-navigation/package.json b/elements/pfe-navigation/package.json
@@ -25,9 +25,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-navigation"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-number/package.json b/elements/pfe-number/package.json
@@ -19,9 +19,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-number"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-page-status/package.json b/elements/pfe-page-status/package.json
@@ -16,9 +16,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-page-status"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-primary-detail/package.json b/elements/pfe-primary-detail/package.json
@@ -24,9 +24,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-primary-detail"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-progress-indicator/package.json b/elements/pfe-progress-indicator/package.json
@@ -19,9 +19,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-progress-indicator"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-progress-steps/package.json b/elements/pfe-progress-steps/package.json
@@ -21,9 +21,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-progress-steps"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-readtime/package.json b/elements/pfe-readtime/package.json
@@ -22,9 +22,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-readtime"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-sass/package.json b/elements/pfe-sass/package.json
@@ -20,9 +20,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-sass"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-styles/package.json b/elements/pfe-styles/package.json
@@ -36,9 +36,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-styles"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-tabs/package.json b/elements/pfe-tabs/package.json
@@ -25,9 +25,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-tabs"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfe-toast/package.json b/elements/pfe-toast/package.json
@@ -16,9 +16,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfe-toast"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/elements/pfelement/package.json b/elements/pfelement/package.json
@@ -24,9 +24,6 @@
     "url": "github:patternfly/patternfly-elements",
     "directory": "elements/pfelement"
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/generators/element/templates/package.json b/generators/element/templates/package.json
@@ -22,9 +22,6 @@
     "directory": "elements/<%= elementName %>"<% } else { %>
     "url": ""<% } %>
   },
-  "engines": {
-    "node": ">=10 <13"
-  },
   "browserslist": [
     "last 2 versions",
     "Firefox >= 78",
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
     "url": "github:patternfly/patternfly-elements"
   },
   "engines": {
-    "node": ">=10 <13"
+    "node": ">=12 <16"
   },
   "browserslist": [
     "last 2 versions",

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ jobs:`
`48`	`48`	`runs-on: ubuntu-latest`
`49`	`49`	`strategy:`
`50`	`50`	`matrix:`
`51`		`- node: ['12.x']`
	`51`	`+ node: ['12.x', '14.x']`
`52`	`52`	`if: \|`
`53`	`53`	`(`
`54`	`54`	`github.event_name == 'pull_request' &&`