Skip to content

Commit ea25cd0

Browse files
Fix: Updated direction for disclosure carets (opened and closed) (#674)
* Changed direction for disclosure carets (opened and closed) * moved caret up slightly when opened. * Added changelog, changed argument name in chevron mixin. * Adjusted vertical position of chevron * made default chevron size smaller Co-authored-by: Kendall Totten <[email protected]>
1 parent 6fbeb73 commit ea25cd0

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

CHANGELOG-prerelease.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ Tag: [v1.0.0-prerelease.34](https://github.com/patternfly/patternfly-elements/re
44

55
- [c2833e3](https://github.com/patternfly/patternfly-elements/commit/c2833e3ef9caa87edbbc56fa22471525d453b7d3) feat: pfe-badge (#625)
66
- [9d9e001](https://github.com/patternfly/patternfly-elements/commit/9d9e00169fe949f78c31211c5d0a4bf3af1dbe9e) fix: Restore clickability of pfe-cta links
7-
- [](https://github.com/patternfly/patternfly-elements/commit/) chore: Update license from 2019 to 2020
7+
- [90855bb](https://github.com/patternfly/patternfly-elements/commit/90855bbc01b800de3280691ee67e61887fd7fe4d) chore: Update license from 2019 to 2020
8+
- [88b26ed](https://github.com/patternfly/patternfly-elements/commit/88b26ed90616651a994890454172be5b4e78db7d) fix: pfe-navigation: Trigger link color, font-size, logo min-width, spacing (#631)
9+
- [](https://github.com/patternfly/patternfly-elements/commit/) Change direction of disclosure carets (#674) (https://github.com/patternfly/patternfly-elements/issues/662)
810

911
## Prerelease 33 ( 2019-12-18 )
1012

elements/pfe-navigation/src/pfe-navigation-item.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,11 +218,11 @@ $variables: map-merge($variables, $nav-item-variables);
218218
&::after {
219219
// closed:
220220
:host([is_nested]:not(.expanded):not([parent_hidden])) & {
221-
@include pfe-chevron($state: closed, $position: 0px);
221+
@include pfe-chevron($state: closed, $offset: 0px);
222222
}
223223
// open:
224224
:host([is_nested].expanded:not([parent_hidden])) & {
225-
@include pfe-chevron($state: open, $position: 4px);
225+
@include pfe-chevron($state: open, $offset: 4px);
226226
}
227227
:host([is_nested]:not([parent_hidden])) & {
228228
--pfe-navigation__trigger-icon--Visible: visible;

elements/pfe-sass/mixins/_components.scss

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,11 +193,12 @@
193193
/// Accordion chevrons
194194
/// ===========================================================================
195195

196-
@mixin pfe-chevron($state: open, $position: after, $size: .4em, $position: $size) {
196+
@mixin pfe-chevron($state: open, $position: after, $size: .4em, $offset: $size) {
197197

198198
content: "";
199199
position: absolute;
200-
top: calc(#{pfe-var(container-spacer)} + #{$position});
200+
top: calc(#{pfe-var(container-spacer)} + #{$offset});
201+
201202
display: block;
202203
border-style: #{pfe-var(surface--border-style)};
203204
height: #{$size};
@@ -207,9 +208,11 @@
207208
border-width: .1em .1em 0 0;
208209
border-bottom: 0;
209210
transform: rotate(-45deg);
210-
top: calc(#{pfe-var(container-spacer)} + #{$position});
211+
top: calc(#{pfe-var(container-spacer)} + #{$offset});
211212
@if $position == before {
212213
left: calc(#{pfe-var(container-spacer)} * 1.5);
214+
top: calc(#{pfe-var(container-spacer)} + .25em);
215+
transform: rotate(135deg);
213216
}
214217
@else {
215218
right: calc(#{pfe-var(container-spacer)} * 1.5);
@@ -220,6 +223,7 @@
220223
transform: rotate(45deg);
221224
@if $position == before {
222225
left: calc(#{pfe-var(container-spacer)} * 1.5);
226+
transform: rotate(-45deg);
223227
}
224228
@else {
225229
right: calc(#{pfe-var(container-spacer)} * 1.5);

0 commit comments

Comments
 (0)