Skip to content

Commit eaf0e25

Browse files
authored
fix: Content set bug with cascading attributes
1 parent 0e67a68 commit eaf0e25

File tree

12 files changed

+629
-294
lines changed

12 files changed

+629
-294
lines changed

CHANGELOG-1.x.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 1.3.1 (2021)
2+
3+
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: Content set bug with cascading attributes in UMD assets
4+
15
# 1.3.0 (2021-02-18)
26

37
### Features

elements/pfe-content-set/demo/index.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ <h3>The pfe-content-set comes with a mutation observer so that you may dynamical
339339
<button id="addHeaderAndPanelBtn">Add Header &amp; Panel</button>
340340
<h2 class="label">Click the button to see it in action!</h2>
341341

342-
<pfe-content-set id="dynamic">
342+
<pfe-content-set id="dynamic" variant="earth" disclosure="true">
343343
<h4 pfe-content-set--header>Heading 1</h4>
344344
<div pfe-content-set--panel>Panel 1. Donec id elit non mi
345345
porta gravida at eget metus. Morbi leo risus, porta ac consectetur ac, vestibulum at eros. Maecenas faucibus
@@ -536,10 +536,12 @@ <h2>Content 2</h2>
536536
var header = document.createElement("h4");
537537
header.setAttribute("pfe-content-set--header", true);
538538
header.textContent = "New heading";
539+
header.id = "newHeader";
539540

540541
var panel = document.createElement("div");
541542
panel.setAttribute("pfe-content-set--panel", true);
542543
panel.textContent = "New panel";
544+
panel.id = "newPanel";
543545

544546
fragment.appendChild(header);
545547
fragment.appendChild(panel);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
<slot id="lightdom" hidden></slot>
1+
<div hidden><slot id="lightdom"></slot></div>
22
<slot name="_view" private></slot>

0 commit comments

Comments
 (0)