chore: reverted combobox controller changes

Author: ArathyKumar

core/pfe-core/controllers/combobox-controller.ts

@@ -525,39 +525,19 @@ export class ComboboxController<
   }
 
   #filterItems() {
-    if (!this.#input) {
-      return;
-    }
-    const value = this.options.getComboboxValue(this.#input);
-    let filteredOption = 0;
-    for (const item of this.items) {
-      const isExpanded = this.options.isExpanded?.() ?? false;
-      const matchesFilter = this.options.isItemFiltered?.(item, value) ?? false;
-      // Increment the filtered option list count by 1 to limit the no of options shown
-      if (!isExpanded || !matchesFilter) {
-        filteredOption++;
+    if (this.#input) {
+      let value: string;
+      for (const item of this.items) {
+        const hidden =
+          !!this.options.isExpanded()
+            && !!(value = this.options.getComboboxValue(this.#input))
+            && this.options.isItemFiltered?.(item, value)
+            || false;
+        this.options.setItemHidden(item, hidden);
       }
-      // Determine if the item should be hidden
-      const hidden = (isExpanded && matchesFilter) || filteredOption > 5;
-      this.options.setItemHidden(item, hidden);
     }
   }
 
-  // Commented the actual function for filter and will be uncommenting this
-  // #filterItems() {
-  //   if (this.#input) {
-  //     let value: string;
-  //     for (const item of this.items) {
-  //       const hidden =
-  //         !!this.options.isExpanded()
-  //           && !!(value = this.options.getComboboxValue(this.#input))
-  //           && this.options.isItemFiltered?.(item, value)
-  //           || false;
-  //       this.options.setItemHidden(item, hidden);
-  //     }
-  //   }
-  // }
-
   #onClickButton = () => {
     if (!this.options.isExpanded()) {
       this.#show();

elements/pf-search-input/pf-search-input.css

@@ -189,6 +189,8 @@
 #outer.expanded #listbox-container {
   opacity: 1;
   z-index: 9999 !important;
+	max-height: 220px;
+	overflow: hidden;
 }
 
 #listbox {