Skip to content

Commit f2c6d5e

Browse files
committed
fix: selected property removed
1 parent 46bfb59 commit f2c6d5e

File tree

2 files changed

+27
-41
lines changed

2 files changed

+27
-41
lines changed

elements/pf-search-input/demo/pf-search-input.html

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
<div class="container">
22
<pf-search-input id="search-input" placeholder="Search">
3-
<pf-option value="Alabama"> Alabama </pf-option>
4-
<pf-option value="New Jersey"> New Jersey </pf-option>
5-
<pf-option value="New York"> New York </pf-option>
6-
<pf-option value="New Mexico"> New Mexico </pf-option>
7-
<pf-option value="North Carolina"> North Carolina </pf-option>
8-
<pf-option value="Alabama1"> Alabama 1 </pf-option>
9-
<pf-option value="New Jersey1"> New Jersey 1 </pf-option>
10-
<pf-option value="New York1"> New York 1 </pf-option>
11-
<pf-option value="New Mexico1"> New Mexico 1</pf-option>
12-
<pf-option value="North Carolina1"> North Carolina 1</pf-option>
13-
<pf-option value="Alabama2"> Alabama 2 </pf-option>
14-
<pf-option value="New Jersey2"> New Jersey 2 </pf-option>
15-
<pf-option value="New York2"> New York 2 </pf-option>
16-
<pf-option value="New Mexico2"> New Mexico 2 </pf-option>
17-
<pf-option value="North Carolina2"> North Carolina 2 </pf-option>
18-
<pf-option value="Alabama3"> Alabama 3 </pf-option>
19-
<pf-option value="New Jersey3"> New Jersey 3 </pf-option>
20-
<pf-option value="New York3"> New York 3 </pf-option>
21-
<pf-option value="New Mexico3"> New Mexico 3 </pf-option>
22-
<pf-option value="North Carolina3"> North Carolina 3 </pf-option>
3+
<pf-option>What is Red Hat Enterprise Linux?</pf-option>
4+
<pf-option>How does Red Hat OpenShift work?</pf-option>
5+
<pf-option>Why use Red Hat Ansible for automation?</pf-option>
6+
<pf-option>Where can Red Hat OpenShift be deployed?</pf-option>
7+
<pf-option>When should you use Red Hat Enterprise Linux?</pf-option>
8+
<pf-option>What is Red Hat Satellite?</pf-option>
9+
<pf-option>How does Red Hat integrate with AWS and other clouds?</pf-option>
10+
<pf-option>Why choose Red Hat over other Linux vendors?</pf-option>
11+
<pf-option>Where can I learn Red Hat technologies?</pf-option>
12+
<pf-option>When does support end for RHEL versions?</pf-option>
13+
<pf-option>What are Red Hat certifications?</pf-option>
14+
<pf-option>How do you secure a RHEL server?</pf-option>
15+
<pf-option>Why use OpenShift instead of vanilla Kubernetes?</pf-option>
16+
<pf-option>Where is Red Hat headquartered?</pf-option>
17+
<pf-option>When should you use Red Hat CoreOS?</pf-option>
18+
<pf-option>What is Red Hat Insights?</pf-option>
19+
<pf-option>How do you manage Red Hat subscriptions?</pf-option>
20+
<pf-option>Why is RHEL considered enterprise-grade?</pf-option>
21+
<pf-option>Where can I download RHEL for testing?</pf-option>
22+
<pf-option>When was Red Hat founded?</pf-option>
2323
</pf-search-input>
2424
</div>
2525

elements/pf-search-input/pf-search-input.ts

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -158,18 +158,6 @@ export class PfSearchInput extends LitElement {
158158
}
159159
}
160160

161-
/**
162-
* Set selected option
163-
*/
164-
@property({ hasChanged: (a, b) => !arraysAreEquivalent(a, b) })
165-
set selected(selected: PfOption) {
166-
this.#combobox.selected = [selected];
167-
}
168-
169-
get selected(): PfOption[] {
170-
return this.#combobox.selected;
171-
}
172-
173161
/** List of options */
174162
get options(): PfOption[] {
175163
if (isServer) {
@@ -247,14 +235,6 @@ export class PfSearchInput extends LitElement {
247235
}
248236
}
249237

250-
@observes('selected')
251-
private async selectedChanged(_: PfOption[], selected: PfOption[]) {
252-
this.value = selected.map(x => x.value).join();
253-
await this.updateComplete;
254-
this._toggleInput!.value = this.value;
255-
}
256-
257-
258238
@observes('value')
259239
private valueChanged() {
260240
this.#internals.setFormValue(this.value ?? '');
@@ -325,6 +305,9 @@ export class PfSearchInput extends LitElement {
325305

326306
#onChange() {
327307
this.value = this._toggleInput?.value;
308+
if (this.value !== this.#combobox.selected[0]?.value) {
309+
this.#combobox.selected = [];
310+
}
328311
this.#internals.setFormValue(this.value ?? '');
329312
this.dispatchEvent(new PfSearchChangeEvent());
330313
}
@@ -360,7 +343,10 @@ export class PfSearchInput extends LitElement {
360343

361344
#setItemSelected(item: PfOption, selected: boolean) {
362345
item.selected = selected;
363-
this.#setItemActive(item, selected);
346+
if (selected) {
347+
this.value = item.value;
348+
this._toggleInput!.value = this.value;
349+
}
364350
}
365351

366352
#setItemActive(item: PfOption, active: boolean) {

0 commit comments

Comments
 (0)