Update ARIA label on pfe-accordion (#628)

* issue-627/pfe-accordion-aria

* modify aria role value

* : Update tests and add changelog

Co-authored-by: [ Cassondra ] <[email protected]>

Author: starryeyez024

CHANGELOG-prerelease.md

@@ -2,7 +2,8 @@
 
 Tag: [v1.0.0-prerelease.37](https://github.com/patternfly/patternfly-elements/releases/tag/v1.0.0-prerelease.37)
 
-- [27aa87d3](https://github.com/patternfly/patternfly-elements/commit/082467) fix: reference error when slot is missing in pfe-navigation
+- [6a41811](https://github.com/patternfly/patternfly-elements/commit/6a418112668ba580918ac4a8b4b54e8df05c1155) fix: reference error when slot is missing in pfe-navigation
+- [](https://github.com/patternfly/patternfly-elements/commit/) fix: accordion accessibility improvements; aria-roles corrected
 
 ## Prerelease 36 ( 2020-01-20 )
 
@@ -42,6 +43,7 @@ Tag: [v1.0.0-prerelease.32](https://github.com/patternfly/patternfly-elements/re
 - [ed919e](https://github.com/patternfly/patternfly-elements/commit/ed919ed15bffc03ee8de4539090c5de075f9ba7d) DE21128 Fix: Add support for theme hooks within surface colors mixin
 - [288322](https://github.com/patternfly/patternfly-elements/commit/2883224d927c26af3c7c9b92a9f8a3d2d852edaf) DE21423 Fix: z-index function now correctly prints variable names
 - [959281](https://github.com/patternfly/patternfly-elements/commit/95928118095d235695526d5dd5da9688ebc92fef) DE21491 Fix: Add default broadcast variables to pfe-base.css
+- [3ccec6](3ccec6c82efc52aae67b74072b6c0b8ff1b47f23) Update pfe-cta to include broadcast variables for all variants [#659](https://github.com/patternfly/patternfly-elements/issues/658)
 
 ## Prerelease 31 ( 2019-11-25 )
 

elements/pfe-accordion/src/pfe-accordion.js

@@ -57,7 +57,7 @@ class PfeAccordion extends PFElement {
   connectedCallback() {
     super.connectedCallback();
 
-    this.setAttribute("role", "presentation");
+    this.setAttribute("role", "tablist");
     this.setAttribute("defined", "");
 
     this.addEventListener(PfeAccordion.events.change, this._changeHandler);
@@ -443,7 +443,7 @@ class PfeAccordionHeader extends PFElement {
     }
 
     if (!this.hasAttribute("role")) {
-      this.setAttribute("role", "header");
+      this.setAttribute("role", "heading");
     }
 
     if (!this.pfeId) {

elements/pfe-accordion/test/pfe-accordion_test.html

@@ -104,10 +104,10 @@ <h2>Header</h2>
           const header = pfeAccordion.querySelector('pfe-accordion-header');
           const panel = pfeAccordion.querySelector('pfe-accordion-panel');
 
-          assert.equal(pfeAccordion.getAttribute('role'), 'presentation');
+          assert.equal(pfeAccordion.getAttribute('role'), 'tablist');
           assert.isTrue(pfeAccordion.hasAttribute('defined'));
           assert.isTrue(header.hasAttribute('aria-controls'));
-          assert.equal(header.getAttribute('role'), 'header');
+          assert.equal(header.getAttribute('role'), 'heading');
           assert.isTrue(panel.hasAttribute('aria-labelledby'));
           assert.equal(panel.getAttribute('role'), 'region');
           assert.equal(header.pfeId, panel.getAttribute('aria-labelledby'));
@@ -380,7 +380,7 @@ <h2>Header</h2>
             const newHeaderElement = document.querySelector("#newHeader");
             const newPanelElement = document.querySelector("#newPanel");
 
-            assert.equal(newHeaderElement.getAttribute("role"), "header");
+            assert.equal(newHeaderElement.getAttribute("role"), "heading");
             assert.isTrue(newHeaderElement.hasAttribute("pfe-id"));
             assert.isTrue(newHeaderElement.hasAttribute("aria-controls"));
             assert.equal(newHeaderElement.getAttribute("aria-controls"), newPanelElement.getAttribute("pfe-id"));