Skip to content

Commit 0babc9c

Browse files
karelhaladlabaj
andauthored
Allow sending action which is rendered next to tile title (#283)
* Allow sending action which is rendered next to tile title * Change action to predefined button and add an example * Fix failing A11 tests * Use meta ID if present for card IDs * fix(ascii): Remove ascii doc examples. * fix(lint): Fixed linting issue. --------- Co-authored-by: Donald Labaj <[email protected]>
1 parent f1c5252 commit 0babc9c

40 files changed

+96
-2484
lines changed

packages/dev/quickstart-adoc.js

Lines changed: 0 additions & 283 deletions
This file was deleted.

packages/dev/src/AppContext.tsx

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,11 @@ import './App.css';
22
import { Page } from '@patternfly/react-core';
33
import {
44
LoadingBox,
5-
QuickStart,
65
QuickStartContextProvider,
76
QuickStartContextValues,
87
QuickStartDrawer,
98
useLocalStorage,
109
} from '@patternfly/quickstarts';
11-
import { loadJSONQuickStarts } from './quickstarts-data/asciidoc/quickstartLoader';
1210
import { allQuickStarts as yamlQuickStarts } from './quickstarts-data/quick-start-test-data';
1311
import React from 'react';
1412
import i18n from './i18n/i18n';
@@ -31,22 +29,12 @@ const App: React.FC<AppProps> = ({ children, showCardFooters }) => {
3129
console.log(allQuickStartStates);
3230
}, [allQuickStartStates]);
3331

34-
const [allQuickStarts, setAllQuickStarts] = React.useState<QuickStart[]>([]);
35-
React.useEffect(() => {
36-
const load = async () => {
37-
const masGuidesQuickstarts = await loadJSONQuickStarts('');
38-
setAllQuickStarts(yamlQuickStarts.concat(masGuidesQuickstarts));
39-
};
40-
setTimeout(() => {
41-
load();
42-
}, 500);
43-
}, []);
4432

4533
const language = localStorage.getItem('bridge/language') || 'en';
4634
const resourceBundle = i18n.getResourceBundle(language, 'quickstart');
4735

4836
const valuesForQuickstartContext: QuickStartContextValues = {
49-
allQuickStarts,
37+
allQuickStarts: yamlQuickStarts,
5038
activeQuickStartID,
5139
setActiveQuickStartID,
5240
allQuickStartStates,
@@ -65,7 +53,7 @@ const App: React.FC<AppProps> = ({ children, showCardFooters }) => {
6553

6654
return (
6755
<React.Suspense fallback={<LoadingBox />}>
68-
{allQuickStarts && allQuickStarts.length ? (
56+
{yamlQuickStarts && yamlQuickStarts.length ? (
6957
<QuickStartContextProvider value={valuesForQuickstartContext}>
7058
<QuickStartDrawer>
7159
<Page header={AppHeader} sidebar={AppSidebar} isManagedSidebar>

packages/dev/src/AppProps.tsx

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@ import './App.css';
22
import { Page, Button } from '@patternfly/react-core';
33
import {
44
LoadingBox,
5-
QuickStart,
65
QuickStartContainer,
76
QuickStartContainerProps,
87
useLocalStorage,
98
setQueryArgument,
109
removeQueryArgument,
1110
QUICKSTART_ID_FILTER_KEY,
1211
} from '@patternfly/quickstarts';
13-
import { loadJSONQuickStarts } from './quickstarts-data/asciidoc/quickstartLoader';
1412
import { allQuickStarts as yamlQuickStarts } from './quickstarts-data/quick-start-test-data';
1513
import React from 'react';
1614
import i18n from './i18n/i18n';
@@ -35,31 +33,19 @@ const App: React.FC<AppProps> = ({ children, showCardFooters }) => {
3533
console.log(allQuickStartStates);
3634
}, [allQuickStartStates]);
3735

38-
const [loading, setLoading] = React.useState(true);
39-
const [quickStarts, setQuickStarts] = React.useState<QuickStart[]>([]);
40-
React.useEffect(() => {
41-
const load = async () => {
42-
const masGuidesQuickstarts = await loadJSONQuickStarts('');
43-
setQuickStarts(yamlQuickStarts.concat(masGuidesQuickstarts));
44-
setLoading(false);
45-
};
46-
setTimeout(() => {
47-
load();
48-
}, 500);
49-
}, []);
36+
5037

5138
const withQueryParams = true;
5239

5340
const drawerProps: QuickStartContainerProps = {
54-
quickStarts,
41+
quickStarts: yamlQuickStarts,
5542
activeQuickStartID,
5643
allQuickStartStates,
5744
setActiveQuickStartID,
5845
setAllQuickStartStates,
5946
resourceBundle,
6047
showCardFooters,
6148
language,
62-
loading,
6349
useQueryParams: withQueryParams,
6450
alwaysShowTaskReview: true,
6551
markdown: {

0 commit comments

Comments
 (0)