Skip to content

Commit 640283a

Browse files
committed
update catalog and status filter on state change
1 parent 6e76e7f commit 640283a

File tree

4 files changed

+18
-9
lines changed

4 files changed

+18
-9
lines changed

packages/dev/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"serve": "serve public"
1010
},
1111
"dependencies": {
12-
"@patternfly/quickstarts": "1.0.0-rc.16",
12+
"@patternfly/quickstarts": "1.0.0-rc.17",
1313
"@patternfly/react-core": "^4.101.3",
1414
"asciidoctor": "^2.2.1",
1515
"react": "^16.14.0",

packages/module/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@patternfly/quickstarts",
3-
"version": "1.0.0-rc.16",
3+
"version": "1.0.0-rc.17",
44
"description": "PatternFly quick starts",
55
"files": [
66
"dist"

packages/module/src/QuickStartCatalogPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export const QuickStartCatalogPage: React.FC<QuickStartCatalogPageProps> = ({
7979
)
8080
: allQuickStarts;
8181
setFilteredQuickStarts(filteredQuickStarts);
82-
}, [allQuickStarts]);
82+
}, [allQuickStarts, allQuickStartStates]);
8383

8484
const clearFilters = () => {
8585
setFilter('keyword', '');

packages/module/src/utils/quick-start-context.tsx

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,14 @@ export const QuickStartContextProvider: React.FC<{
9393
...QuickStartContextDefaults,
9494
...value
9595
}
96+
const {
97+
activeQuickStartID,
98+
setActiveQuickStartID,
99+
setAllQuickStartStates,
100+
useQueryParams,
101+
allQuickStartStates,
102+
allQuickStarts
103+
} = combinedValue;
96104
const [quickStarts, setQuickStarts] = React.useState(combinedValue.allQuickStarts);
97105
const [resourceBundle, setResourceBundle] = React.useState({
98106
...en,
@@ -116,7 +124,7 @@ export const QuickStartContextProvider: React.FC<{
116124
const initialSearchQuery = initialSearchParams.get(QUICKSTART_SEARCH_FILTER_KEY) || '';
117125
const initialStatusFilters = initialSearchParams.get(QUICKSTART_STATUS_FILTER_KEY)?.split(',') || [];
118126

119-
const quickStartStatusCount = getQuickStartStatusCount(combinedValue.allQuickStartStates, combinedValue.allQuickStarts);
127+
const quickStartStatusCount = getQuickStartStatusCount(allQuickStartStates, allQuickStarts);
120128
const [statusTypes, setStatusTypes] = React.useState({
121129
[QuickStartStatus.COMPLETE]: findResource('Complete ({{statusCount, number}})').replace('{{statusCount, number}}', quickStartStatusCount[QuickStartStatus.COMPLETE]),
122130
[QuickStartStatus.IN_PROGRESS]: findResource('In progress ({{statusCount, number}})').replace('{{statusCount, number}}', quickStartStatusCount[QuickStartStatus.IN_PROGRESS]),
@@ -134,17 +142,18 @@ export const QuickStartContextProvider: React.FC<{
134142
}
135143
};
136144

137-
const updateAllQuickStarts = (quickStarts: QuickStart[]) => {
138-
setQuickStarts(quickStarts);
139-
const updatedQuickStartStatusCount = getQuickStartStatusCount(combinedValue.allQuickStartStates, quickStarts);
145+
React.useEffect(() => {
146+
const updatedQuickStartStatusCount = getQuickStartStatusCount(allQuickStartStates, quickStarts);
140147
setStatusTypes({
141148
[QuickStartStatus.COMPLETE]: findResource('Complete ({{statusCount, number}})').replace('{{statusCount, number}}', updatedQuickStartStatusCount[QuickStartStatus.COMPLETE]),
142149
[QuickStartStatus.IN_PROGRESS]: findResource('In progress ({{statusCount, number}})').replace('{{statusCount, number}}', updatedQuickStartStatusCount[QuickStartStatus.IN_PROGRESS]),
143150
[QuickStartStatus.NOT_STARTED]: findResource('Not started ({{statusCount, number}})').replace('{{statusCount, number}}', updatedQuickStartStatusCount[QuickStartStatus.NOT_STARTED]),
144151
});
145-
};
152+
}, [allQuickStartStates, quickStarts])
146153

147-
const { activeQuickStartID, setActiveQuickStartID, setAllQuickStartStates, useQueryParams, allQuickStartStates } = combinedValue;
154+
const updateAllQuickStarts = (quickStarts: QuickStart[]) => {
155+
setQuickStarts(quickStarts);
156+
};
148157

149158
const setActiveQuickStart = useCallback(
150159
(quickStartId: string, totalTasks?: number) => {

0 commit comments

Comments
 (0)